Re: [PATCH] Move kern/loader.c to boot.mod and add preboot_support (was Re: Sendkey patch)

From: "Javier Martín" <lordhabbit@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Move kern/loader.c to boot.mod and add preboot_support (was Re: Sendkey patch)
Date: Fri, 05 Sep 2008 18:47:30 +0200	[thread overview]
Message-ID: <1220633250.8537.17.camel@localhost> (raw)
In-Reply-To: <48C15AAF.1090007@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]

El vie, 05-09-2008 a las 18:13 +0200, phcoder escribió:
> Hello. As I said in another email there is no need for it. I send a
> patch for it.
Well, I won't deny the patch is clever and looks good (I haven't tested
it yet). However, taking the generic "boot" command out of kernel and
leaving the several loader-specific assembly routines (which would be
the parts needing relocation) there is as elegant as vogon poetry.
However, if there is no opposition and your patch works fine - I'm about
to test it right now - we can first commit it (thus making core.img
smaller) and then work on getting the loader asm routines out of kernel.

-Habbit

> Vladimir 'phcoder' Serbinenko
> Javier Martín wrote:
> > El mié, 03-09-2008 a las 20:53 +0300, Vesa Jääskeläinen escribió:
> >> phcoder wrote:
> >>> Hello. In this case we can transfer the whole functionality located in
> >>> kern/loader.c to a dedicated module boot.mod. This module will also
> >>> register "boot" command. In this way the encapsulation won't be broken
> >>> and kernel will become even smaller.
> >> Remember that realmode code needs to reside below < 1 MiB. That is the
> >> reason realmode code is embedded in kernel. In there you only see jumps
> >> to RM and back to PM.
> > We could use the relocator functionality that was once discussed here (I
> > don't know if it was finally committed) so that modules could declare
> > "bundles" of code+data to be deployed to RM area. Or make sure every
> > single instruction in there uses 32-bit addressing, together with
> > artificial EIP-relativization of addresses like in drivemap_int13.S
> > 
> > -Habbit
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > Grub-devel@gnu.org
> > http://lists.gnu.org/mailman/listinfo/grub-devel
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 827 bytes --]