From: Max Krasnyansky <maxk@kernel.org>
To: anthony@codemonkey.ws, aurelien@aurel32.net, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, Max Krasnyansky <maxk@kernel.org>
Subject: [PATCH] uhci: Change default transaction lifetime to 32 frames
Date: Sat, 6 Sep 2008 05:40:23 +0000 [thread overview]
Message-ID: <1220679623-7934-1-git-send-email-maxk@kernel.org> (raw)
Transaction lifetime was originally set to 10 frames. That was an arbitrary
number I picked without much thinking :).
I'm changing that to 32 frames because things like interrupt transfers
and such are scheduled at that rate. It seems like 1/32 is accepted as
lowest supported rate. OHCI, for example, defines exactly 32 interrupt
heads.
While testing USB webcam under XP I noticed that interrupt transactions were
being canceled and then resubmitted on a regular basis, which works but is a
waste of CPU cycles. This change fixes that.
All other devices I have are not affected.
Signed-off-by: Max Krasnyansky <maxk@kernel.org>
---
hw/usb-uhci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index 62c743d..b90cf78 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -781,7 +781,7 @@ static int uhci_handle_td(UHCIState *s, uint32_t addr, UHCI_TD *td, uint32_t *in
async = uhci_async_find_td(s, addr, td->token);
if (async) {
/* Already submitted */
- async->valid = 10;
+ async->valid = 32;
if (!async->done)
return 1;
--
1.5.5.1
WARNING: multiple messages have this Message-ID (diff)
From: Max Krasnyansky <maxk@kernel.org>
To: anthony@codemonkey.ws, aurelien@aurel32.net, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, Max Krasnyansky <maxk@kernel.org>
Subject: [Qemu-devel] [PATCH] uhci: Change default transaction lifetime to 32 frames
Date: Sat, 6 Sep 2008 05:40:23 +0000 [thread overview]
Message-ID: <1220679623-7934-1-git-send-email-maxk@kernel.org> (raw)
Transaction lifetime was originally set to 10 frames. That was an arbitrary
number I picked without much thinking :).
I'm changing that to 32 frames because things like interrupt transfers
and such are scheduled at that rate. It seems like 1/32 is accepted as
lowest supported rate. OHCI, for example, defines exactly 32 interrupt
heads.
While testing USB webcam under XP I noticed that interrupt transactions were
being canceled and then resubmitted on a regular basis, which works but is a
waste of CPU cycles. This change fixes that.
All other devices I have are not affected.
Signed-off-by: Max Krasnyansky <maxk@kernel.org>
---
hw/usb-uhci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index 62c743d..b90cf78 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -781,7 +781,7 @@ static int uhci_handle_td(UHCIState *s, uint32_t addr, UHCI_TD *td, uint32_t *in
async = uhci_async_find_td(s, addr, td->token);
if (async) {
/* Already submitted */
- async->valid = 10;
+ async->valid = 32;
if (!async->done)
return 1;
--
1.5.5.1
next reply other threads:[~2008-09-06 5:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 5:40 Max Krasnyansky [this message]
2008-09-06 5:40 ` [Qemu-devel] [PATCH] uhci: Change default transaction lifetime to 32 frames Max Krasnyansky
2008-09-11 20:59 ` Anthony Liguori
2008-09-11 20:59 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220679623-7934-1-git-send-email-maxk@kernel.org \
--to=maxk@kernel.org \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.