From: Liam Girdwood <lrg@kernel.org>
To: Alan Horstmann <gineera@aspect135.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Cliff Cai <cliff.cai@analog.com>,
ALSA devel <alsa-devel@alsa-project.org>,
Mark Brown <broonie@sirena.org.uk>,
Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH 7/8] ASoC: Add SPI support for WM8731
Date: Tue, 09 Sep 2008 10:03:58 +0100 [thread overview]
Message-ID: <1220951038.17091.177.camel@odin> (raw)
In-Reply-To: <200809090945.35359.gineera@aspect135.co.uk>
On Tue, 2008-09-09 at 09:45 +0100, Alan Horstmann wrote:
> On Monday 08 September 2008 21:51, you wrote:
> > On Mon, Sep 08, 2008 at 09:27:13PM +0100, Alan Horstmann wrote:
> > > Attached and here inline is the small change we applied to ensure the
> > > byte order is correct in the _spi_write function. Note we observed the
> > > spi bus
> >
> > I take it you're happy to give this your Signed-off-by?
>
> Yes, fine, though obviously we haven't tested this with any other soc systems.
>
> wm8731_spi_write_byte_order.patch
>
> Ensure wm8731_spi_write byte order is consistent regardless of endianess.
>
> Signed-off-by: Alan Horstmann <gineera@aspect135.co.uk>
>
Might be worth rolling this out to other SPI capable codecs too.....
Liam
next prev parent reply other threads:[~2008-09-09 9:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 17:46 [PATCH 1/8] ASoC: Make all codecs depend on rather than selecting I2C Mark Brown
2008-09-01 17:46 ` [PATCH 2/8] ASoC: Convert uda1380 to a new-style i2c driver Mark Brown
2008-09-01 17:46 ` [PATCH 3/8] ASoC: Convert ak4535 " Mark Brown
2008-09-01 17:47 ` [PATCH 4/8] ASoC: Convert wm8750 " Mark Brown
2008-09-01 17:47 ` [PATCH 5/8] ASoC: Convert wm8731 " Mark Brown
2008-09-01 17:47 ` [PATCH 6/8] ASoC: Convert wm8990 " Mark Brown
2008-09-01 17:47 ` [PATCH 7/8] ASoC: Add SPI support for WM8731 Mark Brown
2008-09-01 17:47 ` [PATCH 8/8] ASoC: Don't suggest compile time selection of codec access Mark Brown
2008-09-03 16:01 ` [PATCH 7/8] ASoC: Add SPI support for WM8731 Alan Horstmann
2008-09-03 16:01 ` Mark Brown
2008-09-04 1:46 ` Bryan Wu
2008-09-04 10:48 ` Alan Horstmann
2008-09-08 13:52 ` Mark Brown
2008-09-08 20:27 ` Alan Horstmann
2008-09-08 20:51 ` Mark Brown
2008-09-09 8:45 ` Alan Horstmann
2008-09-09 9:03 ` Liam Girdwood [this message]
2008-09-09 9:35 ` Mark Brown
2008-09-09 9:46 ` Liam Girdwood
2008-09-09 9:55 ` Mark Brown
2008-09-02 9:28 ` [PATCH 1/8] ASoC: Make all codecs depend on rather than selecting I2C Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220951038.17091.177.camel@odin \
--to=lrg@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=broonie@sirena.org.uk \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
--cc=gineera@aspect135.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.