From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alan Horstmann <gineera@aspect135.co.uk>
Cc: Cliff Cai <cliff.cai@analog.com>, Bryan Wu <cooloney@kernel.org>,
ALSA devel <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@kernel.org>
Subject: Re: [PATCH 7/8] ASoC: Add SPI support for WM8731
Date: Mon, 8 Sep 2008 14:52:01 +0100 [thread overview]
Message-ID: <20080908135201.GA11376@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <200809041148.29439.gineera@aspect135.co.uk>
On Thu, Sep 04, 2008 at 11:48:29AM +0100, Alan Horstmann wrote:
> I assume that spi_transfer sends bytes in order, from the tx_buf position, and
> it seems clear that data[0] is the high byte that should go first. As msg[2]
> is u16 (why?), I would have thought that the byte at &msg[0] would be the low
> byte on LE, high byte on BE so it would only be correct on BE.
Your analysis makes sense to me.
> Changing the code to use
...
> fixes the problem here.
Could you supply a patch, please?
next prev parent reply other threads:[~2008-09-08 13:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 17:46 [PATCH 1/8] ASoC: Make all codecs depend on rather than selecting I2C Mark Brown
2008-09-01 17:46 ` [PATCH 2/8] ASoC: Convert uda1380 to a new-style i2c driver Mark Brown
2008-09-01 17:46 ` [PATCH 3/8] ASoC: Convert ak4535 " Mark Brown
2008-09-01 17:47 ` [PATCH 4/8] ASoC: Convert wm8750 " Mark Brown
2008-09-01 17:47 ` [PATCH 5/8] ASoC: Convert wm8731 " Mark Brown
2008-09-01 17:47 ` [PATCH 6/8] ASoC: Convert wm8990 " Mark Brown
2008-09-01 17:47 ` [PATCH 7/8] ASoC: Add SPI support for WM8731 Mark Brown
2008-09-01 17:47 ` [PATCH 8/8] ASoC: Don't suggest compile time selection of codec access Mark Brown
2008-09-03 16:01 ` [PATCH 7/8] ASoC: Add SPI support for WM8731 Alan Horstmann
2008-09-03 16:01 ` Mark Brown
2008-09-04 1:46 ` Bryan Wu
2008-09-04 10:48 ` Alan Horstmann
2008-09-08 13:52 ` Mark Brown [this message]
2008-09-08 20:27 ` Alan Horstmann
2008-09-08 20:51 ` Mark Brown
2008-09-09 8:45 ` Alan Horstmann
2008-09-09 9:03 ` Liam Girdwood
2008-09-09 9:35 ` Mark Brown
2008-09-09 9:46 ` Liam Girdwood
2008-09-09 9:55 ` Mark Brown
2008-09-02 9:28 ` [PATCH 1/8] ASoC: Make all codecs depend on rather than selecting I2C Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080908135201.GA11376@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
--cc=gineera@aspect135.co.uk \
--cc=lrg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.