From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Pierre Morel <pmorel@linux.vnet.ibm.com>
Cc: sameske@linux.vnet.ibm.com,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
gregkh@suse.de, Ingo Molnar <mingo@elte.hu>,
Heiko Carstens <heicars2@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Daniel Lezcano <dlezcano@fr.ibm.com>,
Cedric Le Goater <clg@fr.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@tv-sign.ru>,
Roland McGrath <roland@redhat.com>
Subject: Re: [uml-devel] [PATCH 1/1] system call notification with self_ptrace
Date: Wed, 10 Sep 2008 09:19:34 -0700 [thread overview]
Message-ID: <1221063574.6781.8.camel@nimitz> (raw)
In-Reply-To: <48C51439.7000706@linux.vnet.ibm.com>
On Mon, 2008-09-08 at 14:02 +0200, Pierre Morel wrote:
>
> + if (is_self_ptracing(regs->gprs[2])) {
> + if (!entryexit) {
> + struct siginfo info;
> +
> + memset(&info, 0, sizeof(struct siginfo));
> + info.si_signo = SIGSYS;
> + info.si_code = SYS_SYSCALL;
> + info.si_errno = regs->gprs[2];
> + info.si_addr = (void *)regs->orig_gpr2;
> + send_sig_info(SIGSYS, &info, current);
> + regs->gprs[2] = -1;
> + }
> + return;
> + }
I see you didn't like my suggestions for consolidating some of these
repetitive code bits across all the architectures. Did you give that a
a shot? Would you like me to produce a patch on top of what you have
here before this gets merged into mm?
-- Dave
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Pierre Morel <pmorel@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@tv-sign.ru>,
Roland McGrath <roland@redhat.com>,
Heiko Carstens <heicars2@linux.vnet.ibm.com>,
sameske@linux.vnet.ibm.com,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Ingo Molnar <mingo@elte.hu>,
gregkh@suse.de,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
Cedric Le Goater <clg@fr.ibm.com>,
Daniel Lezcano <dlezcano@fr.ibm.com>
Subject: Re: [PATCH 1/1] system call notification with self_ptrace
Date: Wed, 10 Sep 2008 09:19:34 -0700 [thread overview]
Message-ID: <1221063574.6781.8.camel@nimitz> (raw)
In-Reply-To: <48C51439.7000706@linux.vnet.ibm.com>
On Mon, 2008-09-08 at 14:02 +0200, Pierre Morel wrote:
>
> + if (is_self_ptracing(regs->gprs[2])) {
> + if (!entryexit) {
> + struct siginfo info;
> +
> + memset(&info, 0, sizeof(struct siginfo));
> + info.si_signo = SIGSYS;
> + info.si_code = SYS_SYSCALL;
> + info.si_errno = regs->gprs[2];
> + info.si_addr = (void *)regs->orig_gpr2;
> + send_sig_info(SIGSYS, &info, current);
> + regs->gprs[2] = -1;
> + }
> + return;
> + }
I see you didn't like my suggestions for consolidating some of these
repetitive code bits across all the architectures. Did you give that a
a shot? Would you like me to produce a patch on top of what you have
here before this gets merged into mm?
-- Dave
next prev parent reply other threads:[~2008-09-10 17:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 12:02 [uml-devel] [PATCH 1/1] system call notification with self_ptrace Pierre Morel
2008-09-08 12:02 ` Pierre Morel
2008-09-09 0:04 ` Andrew Morton
2008-09-09 0:04 ` [uml-devel] " Andrew Morton
2008-09-10 14:17 ` Pierre Morel
2008-09-10 14:17 ` [uml-devel] " Pierre Morel
2008-09-09 12:43 ` Oleg Nesterov
2008-09-09 12:43 ` Oleg Nesterov
2008-09-10 15:11 ` [uml-devel] " Pierre Morel
2008-09-10 15:11 ` Pierre Morel
2008-09-10 16:20 ` [uml-devel] " Oleg Nesterov
2008-09-10 16:20 ` Oleg Nesterov
2008-09-10 16:23 ` [uml-devel] " Dave Hansen
2008-09-10 16:23 ` Dave Hansen
2008-09-12 12:22 ` [uml-devel] " Pierre Morel
2008-09-12 12:22 ` Pierre Morel
2008-09-12 12:19 ` [uml-devel] " Pierre Morel
2008-09-12 12:19 ` Pierre Morel
2008-09-12 14:32 ` [uml-devel] " Oleg Nesterov
2008-09-12 14:32 ` Oleg Nesterov
2008-09-10 16:19 ` Dave Hansen [this message]
2008-09-10 16:19 ` Dave Hansen
2008-09-12 12:30 ` [uml-devel] " Pierre Morel
2008-09-12 12:30 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221063574.6781.8.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=clg@fr.ibm.com \
--cc=dlezcano@fr.ibm.com \
--cc=gregkh@suse.de \
--cc=heicars2@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=pmorel@linux.vnet.ibm.com \
--cc=roland@redhat.com \
--cc=sameske@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.