From: Hans-Frieder Vogt <hfvogt@gmx.net>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: m.chehab@samsung.com, crope@iki.fi, linux-media@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 05/19] media: Change variable type to bool
Date: Sat, 28 Sep 2013 09:39:47 +0000 [thread overview]
Message-ID: <12218816.0kAuduDdYP@maximilian> (raw)
In-Reply-To: <1379802471-30252-5-git-send-email-peter.senna@gmail.com>
Am Sonntag, 22. September 2013, 00:27:37 schrieb Peter Senna Tschudin:
> The variable vco_select is only assigned the values true and false.
> Change its type to bool.
>
> The simplified semantic patch that find this problem is as
> follows (http://coccinelle.lip6.fr/):
>
> @exists@
> type T;
> identifier b;
> @@
> - T
> + bool
> b = ...;
> ... when any
> b = \(true\|false\)
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/media/tuners/fc0012.c | 2 +-
> drivers/media/tuners/fc0013.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/tuners/fc0012.c b/drivers/media/tuners/fc0012.c
> index f4d0e79..d74e920 100644
> --- a/drivers/media/tuners/fc0012.c
> +++ b/drivers/media/tuners/fc0012.c
> @@ -139,7 +139,7 @@ static int fc0012_set_params(struct dvb_frontend *fe)
> unsigned char reg[7], am, pm, multi, tmp;
> unsigned long f_vco;
> unsigned short xtal_freq_khz_2, xin, xdiv;
> - int vco_select = false;
> + bool vco_select = false;
>
> if (fe->callback) {
> ret = fe->callback(priv->i2c, DVB_FRONTEND_COMPONENT_TUNER,
> diff --git a/drivers/media/tuners/fc0013.c b/drivers/media/tuners/fc0013.c
> index bd8f0f1..b416231 100644
> --- a/drivers/media/tuners/fc0013.c
> +++ b/drivers/media/tuners/fc0013.c
> @@ -233,7 +233,7 @@ static int fc0013_set_params(struct dvb_frontend *fe)
> unsigned char reg[7], am, pm, multi, tmp;
> unsigned long f_vco;
> unsigned short xtal_freq_khz_2, xin, xdiv;
> - int vco_select = false;
> + bool vco_select = false;
>
> if (fe->callback) {
> ret = fe->callback(priv->i2c, DVB_FRONTEND_COMPONENT_TUNER,
Acked-by: Hans-Frieder Vogt <hfvogt@gmx.net>
Hans-Frieder Vogt e-mail: hfvogt <at> gmx .dot. net
WARNING: multiple messages have this Message-ID (diff)
From: Hans-Frieder Vogt <hfvogt@gmx.net>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: m.chehab@samsung.com, crope@iki.fi, linux-media@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 05/19] media: Change variable type to bool
Date: Sat, 28 Sep 2013 11:39:47 +0200 [thread overview]
Message-ID: <12218816.0kAuduDdYP@maximilian> (raw)
In-Reply-To: <1379802471-30252-5-git-send-email-peter.senna@gmail.com>
Am Sonntag, 22. September 2013, 00:27:37 schrieb Peter Senna Tschudin:
> The variable vco_select is only assigned the values true and false.
> Change its type to bool.
>
> The simplified semantic patch that find this problem is as
> follows (http://coccinelle.lip6.fr/):
>
> @exists@
> type T;
> identifier b;
> @@
> - T
> + bool
> b = ...;
> ... when any
> b = \(true\|false\)
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/media/tuners/fc0012.c | 2 +-
> drivers/media/tuners/fc0013.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/tuners/fc0012.c b/drivers/media/tuners/fc0012.c
> index f4d0e79..d74e920 100644
> --- a/drivers/media/tuners/fc0012.c
> +++ b/drivers/media/tuners/fc0012.c
> @@ -139,7 +139,7 @@ static int fc0012_set_params(struct dvb_frontend *fe)
> unsigned char reg[7], am, pm, multi, tmp;
> unsigned long f_vco;
> unsigned short xtal_freq_khz_2, xin, xdiv;
> - int vco_select = false;
> + bool vco_select = false;
>
> if (fe->callback) {
> ret = fe->callback(priv->i2c, DVB_FRONTEND_COMPONENT_TUNER,
> diff --git a/drivers/media/tuners/fc0013.c b/drivers/media/tuners/fc0013.c
> index bd8f0f1..b416231 100644
> --- a/drivers/media/tuners/fc0013.c
> +++ b/drivers/media/tuners/fc0013.c
> @@ -233,7 +233,7 @@ static int fc0013_set_params(struct dvb_frontend *fe)
> unsigned char reg[7], am, pm, multi, tmp;
> unsigned long f_vco;
> unsigned short xtal_freq_khz_2, xin, xdiv;
> - int vco_select = false;
> + bool vco_select = false;
>
> if (fe->callback) {
> ret = fe->callback(priv->i2c, DVB_FRONTEND_COMPONENT_TUNER,
Acked-by: Hans-Frieder Vogt <hfvogt@gmx.net>
Hans-Frieder Vogt e-mail: hfvogt <at> gmx .dot. net
next prev parent reply other threads:[~2013-09-28 9:39 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 22:27 [PATCH 01/19] arm: Change variable type to bool Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 02/19] hv: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-23 12:01 ` Dan Carpenter
2013-09-23 12:01 ` Dan Carpenter
2013-09-21 22:27 ` [PATCH 03/19] infiniband: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 04/19] isdn: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 05/19] media: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-28 9:39 ` Hans-Frieder Vogt [this message]
2013-09-28 9:39 ` Hans-Frieder Vogt
2013-09-21 22:27 ` [PATCH 06/19] " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 07/19] mmc: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 08/19] net: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 09/19] " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-23 21:38 ` David Miller
2013-09-23 21:38 ` David Miller
2013-09-21 22:27 ` [PATCH 10/19] " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 11/19] wireless: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-23 19:40 ` Bing Zhao
2013-09-23 19:40 ` Bing Zhao
2013-09-21 22:27 ` [PATCH 12/19] " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-22 8:22 ` Joe Perches
2013-09-22 8:22 ` Joe Perches
2013-09-24 10:54 ` Kalle Valo
2013-09-24 10:54 ` Kalle Valo
2013-09-21 22:27 ` [PATCH 13/19] rtc: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 14/19] scsi: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 15/19] staging: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 23:15 ` Greg KH
2013-09-21 23:15 ` Greg KH
2013-09-21 22:27 ` [PATCH 16/19] " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 17/19] " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-22 13:35 ` Pavel Machek
2013-09-22 13:35 ` Pavel Machek
2013-09-21 22:27 ` [PATCH 18/19] nilfs2: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
2013-09-21 22:27 ` [PATCH 19/19] net: " Peter Senna Tschudin
2013-09-21 22:27 ` Peter Senna Tschudin
[not found] ` <43e0f3a4fb62473e9bdd308a8dc4490f@fmsmsx104.amr.corp.intel.com>
2013-09-23 14:11 ` [PATCH 14/19] scsi: " Dorau, Lukasz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12218816.0kAuduDdYP@maximilian \
--to=hfvogt@gmx.net \
--cc=crope@iki.fi \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.