[PATCH] gitattributes documentation: link to gitignore for glob format

[PATCH] gitattributes documentation: link to gitignore for glob format

[Nguyễn Thái Ngọc Duy]

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 Documentation/gitattributes.txt |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
index 9a75257..45c11df 100644
--- a/Documentation/gitattributes.txt
+++ b/Documentation/gitattributes.txt
@@ -21,7 +21,9 @@ Each line in `gitattributes` file is of form:
 	glob	attr1 attr2 ...
 
 That is, a glob pattern followed by an attributes list,
-separated by whitespaces.  When the glob pattern matches the
+separated by whitespaces. Glob pattern format is as same as
+one used by `gitignore` files. Please refer to linkgit:gitignore[5]
+for more information. When the glob pattern matches the
 path in question, the attributes listed on the line are given to
 the path.
 
-- 
1.6.0.2.427.g8dbf1

Re: [PATCH] gitattributes documentation: link to gitignore for glob format

[Wincent Colaiuta]

El 21/9/2008, a las 14:43, Nguyễn Thái Ngọc Duy escribió:

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> Documentation/gitattributes.txt |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/gitattributes.txt b/Documentation/ 
> gitattributes.txt
> index 9a75257..45c11df 100644
> --- a/Documentation/gitattributes.txt
> +++ b/Documentation/gitattributes.txt
> @@ -21,7 +21,9 @@ Each line in `gitattributes` file is of form:
> 	glob	attr1 attr2 ...
>
> That is, a glob pattern followed by an attributes list,
> -separated by whitespaces.  When the glob pattern matches the
> +separated by whitespaces. Glob pattern format is as same as

It's "whitespace", not "whitespaces". And the sentence you added has  
two errors:

"as same as" should be "the same as"

> +one used by `gitignore` files. Please refer to linkgit:gitignore[5]
> +for more information. When the glob pattern matches the

And: "as one" should be "as the one".

And as a style point, you probably should start the sentence with "The  
glob pattern" rather than "Glob pattern".

Did you actually proofread this before sending it?

Cheers,
Wincent

[PATCH] gitattributes documentation: link to gitignore for glob format

[Nguyễn Thái Ngọc Duy]

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 On 9/21/08, Wincent Colaiuta <win@wincent.com> wrote:
 >  Did you actually proofread this before sending it?

 I did, but obviously I should have been more serious on
 English classes.

 Documentation/gitattributes.txt |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
index 9a75257..708a9b5 100644
--- a/Documentation/gitattributes.txt
+++ b/Documentation/gitattributes.txt
@@ -21,7 +21,9 @@ Each line in `gitattributes` file is of form:
 	glob	attr1 attr2 ...
 
 That is, a glob pattern followed by an attributes list,
-separated by whitespaces.  When the glob pattern matches the
+separated by whitespace. The glob pattern format is the same as
+the one used by `gitignore` files. Please refer to linkgit:gitignore[5]
+for more information. When the glob pattern matches the
 path in question, the attributes listed on the line are given to
 the path.
 
-- 
1.6.0.2.427.g8dbf1