From: Harvey Harrison <harvey.harrison@gmail.com>
To: Willy Tarreau <w@1wt.eu>
Cc: David Miller <davem@davemloft.net>,
nickolay@protei.ru, linux-kernel@vger.kernel.org,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: SCTP checksum patch for 2.6.26.5
Date: Tue, 23 Sep 2008 05:45:18 +0000 [thread overview]
Message-ID: <1222148718.16003.1.camel@brick> (raw)
In-Reply-To: <20080923051920.GD24654@1wt.eu>
On Tue, 2008-09-23 at 07:19 +0200, Willy Tarreau wrote:
> On Mon, Sep 22, 2008 at 01:12:45PM -0700, David Miller wrote:
> > From: Nickolay Vinogradov <nickolay@protei.ru>
> > Date: Mon, 22 Sep 2008 19:58:26 +0400
> >
> > CC:'ing correct mailing lists...
> >
> Nickolay,
>
> you should use swab32(~crc32) instead. It will make use of arch-specific
> optimisations when available (eg: bswap on x86).
>
> Willy
Or look at:
commit 336d3262df71fcd2661180bb35d5ea41b4cbca58
Author: Harvey Harrison <harvey.harrison@gmail.com>
Date: Fri Jul 18 23:07:09 2008 -0700
sctp: remove unnecessary byteshifting, calculate directly in big-endian
In Linus' tree.
Cheers,
Harvey
WARNING: multiple messages have this Message-ID (diff)
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Willy Tarreau <w@1wt.eu>
Cc: David Miller <davem@davemloft.net>,
nickolay@protei.ru, linux-kernel@vger.kernel.org,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: SCTP checksum patch for 2.6.26.5
Date: Mon, 22 Sep 2008 22:45:18 -0700 [thread overview]
Message-ID: <1222148718.16003.1.camel@brick> (raw)
In-Reply-To: <20080923051920.GD24654@1wt.eu>
On Tue, 2008-09-23 at 07:19 +0200, Willy Tarreau wrote:
> On Mon, Sep 22, 2008 at 01:12:45PM -0700, David Miller wrote:
> > From: Nickolay Vinogradov <nickolay@protei.ru>
> > Date: Mon, 22 Sep 2008 19:58:26 +0400
> >
> > CC:'ing correct mailing lists...
> >
> Nickolay,
>
> you should use swab32(~crc32) instead. It will make use of arch-specific
> optimisations when available (eg: bswap on x86).
>
> Willy
Or look at:
commit 336d3262df71fcd2661180bb35d5ea41b4cbca58
Author: Harvey Harrison <harvey.harrison@gmail.com>
Date: Fri Jul 18 23:07:09 2008 -0700
sctp: remove unnecessary byteshifting, calculate directly in big-endian
In Linus' tree.
Cheers,
Harvey
next prev parent reply other threads:[~2008-09-23 5:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 15:58 SCTP checksum patch for 2.6.26.5 Nickolay Vinogradov
2008-09-22 20:12 ` David Miller
2008-09-22 20:12 ` David Miller
2008-09-22 20:36 ` Vlad Yasevich
2008-09-22 20:36 ` Vlad Yasevich
2008-09-23 5:19 ` Willy Tarreau
2008-09-23 5:19 ` Willy Tarreau
2008-09-23 5:45 ` Harvey Harrison [this message]
2008-09-23 5:45 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222148718.16003.1.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nickolay@protei.ru \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.