All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	serue@linux.vnet.ibm.com, zohar@linux.vnet.ibm.com,
	safford@watson.ibm.com, debora@linux.vnet.ibm.com
Subject: Re: [PATCH 3/4][resubmit] TPM: rcu locking
Date: Wed, 24 Sep 2008 10:10:41 -0300	[thread overview]
Message-ID: <1222261841.24276.28.camel@blackbox> (raw)
In-Reply-To: <1222201173.24276.15.camel@blackbox>

Reading the code again, we noticed that there's a put_device() missing
right inside this test:

>  	if (test_and_set_bit(0, &chip->is_open)) {
>  		dev_dbg(chip->dev, "Another process owns this TPM\n");
> -		rc = -EBUSY;
> -		goto err_out;
> +		return -EBUSY;
>  	}
> 
Since this was moved to a section before.
> -	get_device(chip->dev);
> -

I'll submit a patch to be applied on top of this one.

Rajiv Andrade
IBM Linux Technology Center
Security Development



  parent reply	other threads:[~2008-09-24 13:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-23 17:19 [PATCH 0/4] BKL removed, RCU addition and pnp remove Rajiv Andrade
2008-09-23 17:19 ` [PATCH 1/4] TPM: update char dev BKL pushdown Rajiv Andrade
2008-09-23 20:58   ` Jonathan Corbet
2008-09-24 13:14     ` Rajiv Andrade
2008-09-23 17:19 ` [PATCH 2/4] TPM: num_opens to is_open variable change Rajiv Andrade
2008-09-23 17:19 ` [PATCH 3/4] TPM: rcu locking Rajiv Andrade
2008-09-23 18:19   ` Paul E. McKenney
2008-09-23 20:18     ` Rajiv Andrade
2008-09-23 20:27       ` Paul E. McKenney
2008-09-25 13:36         ` Serge E. Hallyn
2008-09-25 14:33           ` Paul E. McKenney
2008-09-25 14:59             ` Serge E. Hallyn
2008-09-23 20:19     ` [PATCH 3/4][resubmit] " Rajiv Andrade
2008-09-23 21:01       ` Jonathan Corbet
2008-09-23 21:27         ` Mimi Zohar
2008-09-24 13:10       ` Rajiv Andrade [this message]
2008-09-25 13:39         ` Serge E. Hallyn
2008-09-25 13:29   ` [PATCH 3/4] " Serge E. Hallyn
2008-09-23 17:19 ` [PATCH 4/4] TPM: addition of pnp remove Rajiv Andrade
2008-09-23 17:38   ` about kernel_physical_mapping_init Joilnen Leite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222261841.24276.28.camel@blackbox \
    --to=srajiv@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=debora@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=safford@watson.ibm.com \
    --cc=serue@linux.vnet.ibm.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.