From: Artem Bityutskiy <dedekind@infradead.org>
To: Kyungmin Park <kmpark@infradead.org>
Cc: apgmoorthy <moorthy.apg@samsung.com>,
linux-mtd@lists.infradead.org, David.Woodhouse@intel.com
Subject: Re: [PATCH] [MTD-UTILS] Add support for 4KB page flash devices
Date: Fri, 26 Sep 2008 07:48:53 +0300 [thread overview]
Message-ID: <1222404533.5012.1.camel@sauron> (raw)
In-Reply-To: <9c9fda240809251728u71366888s9cf81b4eac99472d@mail.gmail.com>
Hi,
On Fri, 2008-09-26 at 09:28 +0900, Kyungmin Park wrote:
> > We can now use these utilities on 4KB devices.
> >
> > Signed-off-by: Rohit Hagargundgi <h.rohit@samsung.com>
> > ---
>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Err, isn't this ABI change which is going to break backward
compatibility and is NO-NO in Linux?
> > }
> > --- a/include/mtd/mtd-abi.h 2008-09-23 15:36:26.000000000 +0530
> > +++ b/include/mtd/mtd-abi.h 2008-09-23 15:48:48.000000000 +0530
> > @@ -104,7 +104,7 @@ struct nand_oobinfo {
> > uint32_t useecc;
> > uint32_t eccbytes;
> > uint32_t oobfree[8][2];
> > - uint32_t eccpos[32];
> > + uint32_t eccpos[128];
> > };
Err, isn't this ABI change which is going to break backward
compatibility and is NO-NO in Linux?
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2008-09-26 4:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 12:41 [PATCH] [MTD-UTILS] Add support for 4KB page flash devices AYYANARPONNUSAMY GANGHEYAMOORTHY
2008-09-22 6:22 ` Kyungmin Park
2008-09-22 9:19 ` Sergei Shtylyov
2008-09-23 11:25 ` apgmoorthy
2008-09-26 0:28 ` Kyungmin Park
2008-09-26 4:48 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222404533.5012.1.camel@sauron \
--to=dedekind@infradead.org \
--cc=David.Woodhouse@intel.com \
--cc=kmpark@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=moorthy.apg@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.