From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: moorthy.apg@samsung.com, linux-mtd@lists.infradead.org,
David.Woodhouse@intel.com
Subject: Re: [PATCH] [MTD-UTILS] Add support for 4KB page flash devices
Date: Mon, 22 Sep 2008 13:19:29 +0400 [thread overview]
Message-ID: <48D76321.4000105@ru.mvista.com> (raw)
In-Reply-To: <9c9fda240809212322h4d9ac26eqfd7c3cfb9630c97b@mail.gmail.com>
Hello.
Kyungmin Park wrote:
>> We can now use these utilities on 4KB devices.
>>
>> Signed-off-by: Rohit Hagargundgi <h.rohit@samsung.com>
>> ---
>> --- a/flash_otp_write.c 2008-06-27 21:51:28.000000000 +0530
>> +++ b/flash_otp_write.c 2008-07-01 16:04:12.000000000 +0530
>> @@ -18,7 +18,7 @@ int main(int argc,char *argv[])
>> int fd, val, ret, size, wrote, len;
>> mtd_info_t mtdInfo;
>> off_t offset;
>> - char *p, buf[2048];
>> + char *p, buf[4096];
>>
>>
>
> Is it no problem the stack overflow in application?
> How about to use malloc & free?
>
Come on, it's only an extra page of stack for a non-recursive
function -- this shouldn't pose any danger.
WBR, Sergei
next prev parent reply other threads:[~2008-09-22 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 12:41 [PATCH] [MTD-UTILS] Add support for 4KB page flash devices AYYANARPONNUSAMY GANGHEYAMOORTHY
2008-09-22 6:22 ` Kyungmin Park
2008-09-22 9:19 ` Sergei Shtylyov [this message]
2008-09-23 11:25 ` apgmoorthy
2008-09-26 0:28 ` Kyungmin Park
2008-09-26 4:48 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D76321.4000105@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=David.Woodhouse@intel.com \
--cc=kmpark@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=moorthy.apg@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.