All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollisb@us.ibm.com>
To: ehrhardt@linux.vnet.ibm.com
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/3][RESEND] kvm-userspace: kvmppc: fix hostlonbits
Date: Mon, 29 Sep 2008 14:43:52 +0000	[thread overview]
Message-ID: <1222699432.11272.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1222692614-18532-3-git-send-email-ehrhardt@linux.vnet.ibm.com>

On Mon, 2008-09-29 at 14:50 +0200, ehrhardt@linux.vnet.ibm.com wrote:
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
> 
> The kvm merge with qemu brought code for 64bit power that broke cross
> compilation. The issue is caused by configure trying to execute target
> architecture binaries where configure is executed.
> 
> I tried to change that detection so that it works with&without cross
> compilation with only a small change and especially without an addtional
> configure command line switch. Including the bits/wordsize.h header a platform
> usually can check its wordsize and by doing that configure can check the
> hostlongbits without executing the binary. Instead it now stops after
> preprocessing stage which resolved the __WORDSIZE constant and retrieves
> that value.
> 
> I don't like that check style, but it is at least less broken than before.
> Comments and other approaches welcome.

This needs to be CCed to qemu-devel@nongnu.org and applied upstream.

I don't know if bits/wordsize.h is too Linux-specific (or if that even
matters in the configure script).

-- 
Hollis Blanchard
IBM Linux Technology Center


WARNING: multiple messages have this Message-ID (diff)
From: Hollis Blanchard <hollisb@us.ibm.com>
To: ehrhardt@linux.vnet.ibm.com
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/3][RESEND] kvm-userspace: kvmppc: fix hostlonbits detection when cross compiling
Date: Mon, 29 Sep 2008 09:43:52 -0500	[thread overview]
Message-ID: <1222699432.11272.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1222692614-18532-3-git-send-email-ehrhardt@linux.vnet.ibm.com>

On Mon, 2008-09-29 at 14:50 +0200, ehrhardt@linux.vnet.ibm.com wrote:
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
> 
> The kvm merge with qemu brought code for 64bit power that broke cross
> compilation. The issue is caused by configure trying to execute target
> architecture binaries where configure is executed.
> 
> I tried to change that detection so that it works with&without cross
> compilation with only a small change and especially without an addtional
> configure command line switch. Including the bits/wordsize.h header a platform
> usually can check its wordsize and by doing that configure can check the
> hostlongbits without executing the binary. Instead it now stops after
> preprocessing stage which resolved the __WORDSIZE constant and retrieves
> that value.
> 
> I don't like that check style, but it is at least less broken than before.
> Comments and other approaches welcome.

This needs to be CCed to qemu-devel@nongnu.org and applied upstream.

I don't know if bits/wordsize.h is too Linux-specific (or if that even
matters in the configure script).

-- 
Hollis Blanchard
IBM Linux Technology Center


  reply	other threads:[~2008-09-29 14:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29 12:50 [PATCH 0/3][RESEND] kvm-userspace: kvmppc: fix build for ppc ehrhardt
2008-09-29 12:50 ` ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
     [not found] ` <1222692614-18532-1-git-send-email-ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-09-29 12:50   ` [PATCH 1/3][RESEND] kvm-userspace: kvmppc: fix file header in libkvm-powerpc.c ehrhardt
2008-09-29 12:50     ` ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
2008-09-29 12:50   ` [PATCH 2/3][RESEND] kvm-userspace: kvmppc: fix hostlonbits detection when cross compiling ehrhardt
2008-09-29 12:50     ` ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
2008-09-29 14:43     ` Hollis Blanchard [this message]
2008-09-29 14:43       ` Hollis Blanchard
2008-09-29 12:50   ` [PATCH 3/3][RESEND] kvm-userspace: kvmppc: fix building userspace for powerpc ehrhardt
2008-09-29 12:50     ` ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222699432.11272.3.camel@localhost.localdomain \
    --to=hollisb@us.ibm.com \
    --cc=ehrhardt@linux.vnet.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.