From: Matt Mackall <mpm@selenic.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Richard Kennedy <richard@rsk.demon.co.uk>,
penberg <penberg@cs.helsinki.fi>, linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] slub: reduce total stack usage of slab_err & object_err
Date: Tue, 30 Sep 2008 10:49:45 -0500 [thread overview]
Message-ID: <1222789785.23159.27.camel@calx> (raw)
In-Reply-To: <48E2480A.9090003@linux-foundation.org>
On Tue, 2008-09-30 at 10:38 -0500, Christoph Lameter wrote:
> Richard Kennedy wrote:
> > reduce the total stack usage of slab_err & object_err.
> >
> > Introduce a new function to display a simple slab bug message, and call
> > this when vprintk is not needed.
>
> You could simply get rid of the 100 byte buffer by using vprintk? Same method
> could be used elsewhere in the kernel and does not require additional
> functions. Compiles, untestted.
I'm fixing a bunch of these in the kernel right now.
--
Mathematics is the supreme nostalgia of our time.
WARNING: multiple messages have this Message-ID (diff)
From: Matt Mackall <mpm@selenic.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Richard Kennedy <richard@rsk.demon.co.uk>,
penberg <penberg@cs.helsinki.fi>, linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] slub: reduce total stack usage of slab_err & object_err
Date: Tue, 30 Sep 2008 10:49:45 -0500 [thread overview]
Message-ID: <1222789785.23159.27.camel@calx> (raw)
In-Reply-To: <48E2480A.9090003@linux-foundation.org>
On Tue, 2008-09-30 at 10:38 -0500, Christoph Lameter wrote:
> Richard Kennedy wrote:
> > reduce the total stack usage of slab_err & object_err.
> >
> > Introduce a new function to display a simple slab bug message, and call
> > this when vprintk is not needed.
>
> You could simply get rid of the 100 byte buffer by using vprintk? Same method
> could be used elsewhere in the kernel and does not require additional
> functions. Compiles, untestted.
I'm fixing a bunch of these in the kernel right now.
--
Mathematics is the supreme nostalgia of our time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-09-30 15:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 15:15 [PATCH] slub: reduce total stack usage of slab_err & object_err Richard Kennedy
2008-09-30 15:15 ` Richard Kennedy
2008-09-30 15:32 ` Matt Mackall
2008-09-30 15:32 ` Matt Mackall
2008-09-30 15:38 ` Christoph Lameter
2008-09-30 15:38 ` Christoph Lameter
2008-09-30 15:49 ` Matt Mackall [this message]
2008-09-30 15:49 ` Matt Mackall
2008-09-30 16:20 ` Richard Kennedy
2008-09-30 16:20 ` Richard Kennedy
2008-09-30 16:43 ` Matt Mackall
2008-09-30 16:43 ` Matt Mackall
2008-09-30 17:36 ` Christoph Lameter
2008-09-30 17:36 ` Christoph Lameter
2008-09-30 17:37 ` Matt Mackall
2008-09-30 17:37 ` Matt Mackall
2008-09-30 18:33 ` Matt Mackall
2008-09-30 18:33 ` Matt Mackall
2008-10-01 9:50 ` Richard Kennedy
2008-10-01 9:50 ` Richard Kennedy
2008-10-01 0:02 ` Matt Mackall
2008-10-01 0:02 ` Matt Mackall
2008-09-30 19:33 ` Jörn Engel
2008-09-30 19:33 ` Jörn Engel
2008-10-01 10:06 ` Richard Kennedy
2008-10-01 10:06 ` Richard Kennedy
2008-10-01 10:32 ` Jörn Engel
2008-10-01 10:32 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222789785.23159.27.camel@calx \
--to=mpm@selenic.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.