* [PATCH 6/8] docs: add URL for paper on submitting patches
2008-10-09 23:52 [PATCH 1/8 for 2.6.27] docs: fix uvesafb mode_option Randy Dunlap
@ 2008-10-09 23:52 ` Randy Dunlap
2008-10-09 23:52 ` [PATCH 2/8] docs: fix CDROM missing test program reference Randy Dunlap
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2008-10-09 23:52 UTC (permalink / raw)
To: linux-kernel
From: Andi Kleen <ak@linux.intel.com>
Add a reference to paper to SubmittingPatches
For this year's OLS I wrote a paper on successfull strategies
to submit difficult kernel patches. Add a reference to it to
SubmittingPatches.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
Documentation/SubmittingPatches | 5 +++++
1 file changed, 5 insertions(+)
--- linux-2.6.27-rc9-git2.orig/Documentation/SubmittingPatches
+++ linux-2.6.27-rc9-git2/Documentation/SubmittingPatches
@@ -672,4 +672,9 @@ Kernel Documentation/CodingStyle:
Linus Torvalds's mail on the canonical patch format:
<http://lkml.org/lkml/2005/4/7/183>
+
+Andi Kleen, "On submitting kernel patches"
+ Some strategies to get difficult or controversal changes in.
+ http://halobates.de/on-submitting-patches.pdf
+
--
--
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 2/8] docs: fix CDROM missing test program reference
2008-10-09 23:52 [PATCH 1/8 for 2.6.27] docs: fix uvesafb mode_option Randy Dunlap
2008-10-09 23:52 ` [PATCH 6/8] docs: add URL for paper on submitting patches Randy Dunlap
@ 2008-10-09 23:52 ` Randy Dunlap
2008-10-09 23:52 ` [PATCH 5/8] docs: add printk lib. extensions Randy Dunlap
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2008-10-09 23:52 UTC (permalink / raw)
To: linux-kernel
From: Randy Dunlap <randy.dunlap@oracle.com>
Reported-by: Nick Warne <nick@ukfsn.org>
The sbpcd tester program is not included in the kernel source tree,
so remove the reference to it.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
Documentation/cdrom/ide-cd | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.27-rc9-git2.orig/Documentation/cdrom/ide-cd
+++ linux-2.6.27-rc9-git2/Documentation/cdrom/ide-cd
@@ -145,8 +145,7 @@ useful for reading photocds.
To play an audio CD, you should first unmount and remove any data
CDROM. Any of the CDROM player programs should then work (workman,
-workbone, cdplayer, etc.). Lacking anything else, you could use the
-cdtester program in Documentation/cdrom/sbpcd.
+workbone, cdplayer, etc.).
On a few drives, you can read digital audio directly using a program
such as cdda2wav. The only types of drive which I've heard support
--
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 5/8] docs: add printk lib. extensions
2008-10-09 23:52 [PATCH 1/8 for 2.6.27] docs: fix uvesafb mode_option Randy Dunlap
2008-10-09 23:52 ` [PATCH 6/8] docs: add URL for paper on submitting patches Randy Dunlap
2008-10-09 23:52 ` [PATCH 2/8] docs: fix CDROM missing test program reference Randy Dunlap
@ 2008-10-09 23:52 ` Randy Dunlap
2008-10-09 23:52 ` [PATCH 3/8] docs: fix ramfs hello program build name Randy Dunlap
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2008-10-09 23:52 UTC (permalink / raw)
To: linux-kernel
From: Andi Kleen <ak@linux.intel.com>
Add documentation in kerneldoc for new printk format extensions
This patch documents the new %pS/%pF options in printk in kernel doc.
Hope I didn't miss any other extension.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
kernel/printk.c | 2 ++
lib/vsprintf.c | 12 ++++++++++++
2 files changed, 14 insertions(+)
--- linux-2.6.27-rc9-git2.orig/kernel/printk.c
+++ linux-2.6.27-rc9-git2/kernel/printk.c
@@ -593,6 +593,8 @@ static int have_callable_console(void)
*
* See also:
* printf(3)
+ *
+ * See the vsnprintf() documentation for format string extensions over C99.
*/
asmlinkage int printk(const char *fmt, ...)
--- linux-2.6.27-rc9-git2.orig/lib/vsprintf.c
+++ linux-2.6.27-rc9-git2/lib/vsprintf.c
@@ -565,6 +565,10 @@ static char *pointer(const char *fmt, ch
* @fmt: The format string to use
* @args: Arguments for the format string
*
+ * This function follows C99 vsnprintf, but has some extensions:
+ * %pS - output the name of a text symbol
+ * %pF - output the name of a function pointer
+ *
* The return value is the number of characters which would
* be generated for the given input, excluding the trailing
* '\0', as per ISO C99. If you want to have the exact
@@ -806,6 +810,8 @@ EXPORT_SYMBOL(vsnprintf);
*
* Call this function if you are already dealing with a va_list.
* You probably want scnprintf() instead.
+ *
+ * See the vsnprintf() documentation for format string extensions over C99.
*/
int vscnprintf(char *buf, size_t size, const char *fmt, va_list args)
{
@@ -828,6 +834,8 @@ EXPORT_SYMBOL(vscnprintf);
* generated for the given input, excluding the trailing null,
* as per ISO C99. If the return is greater than or equal to
* @size, the resulting string is truncated.
+ *
+ * See the vsnprintf() documentation for format string extensions over C99.
*/
int snprintf(char * buf, size_t size, const char *fmt, ...)
{
@@ -877,6 +885,8 @@ EXPORT_SYMBOL(scnprintf);
*
* Call this function if you are already dealing with a va_list.
* You probably want sprintf() instead.
+ *
+ * See the vsnprintf() documentation for format string extensions over C99.
*/
int vsprintf(char *buf, const char *fmt, va_list args)
{
@@ -894,6 +904,8 @@ EXPORT_SYMBOL(vsprintf);
* The function returns the number of characters written
* into @buf. Use snprintf() or scnprintf() in order to avoid
* buffer overflows.
+ *
+ * See the vsnprintf() documentation for format string extensions over C99.
*/
int sprintf(char * buf, const char *fmt, ...)
{
--
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 3/8] docs: fix ramfs hello program build name
2008-10-09 23:52 [PATCH 1/8 for 2.6.27] docs: fix uvesafb mode_option Randy Dunlap
` (2 preceding siblings ...)
2008-10-09 23:52 ` [PATCH 5/8] docs: add printk lib. extensions Randy Dunlap
@ 2008-10-09 23:52 ` Randy Dunlap
2008-10-09 23:52 ` [PATCH 4/8] docs: fix ManagementStyle book name Randy Dunlap
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2008-10-09 23:52 UTC (permalink / raw)
To: linux-kernel
From: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
A trivial patch on ramfs-rootfs-initramfs.txt
First a file hello.c is created, then the file hello2.c is compiled.
Changed this to hello.c
Mailed this before to trivial@kernel.org only but did not get a reply and
haven't seen it applied yet, so resubmitting to a wider audience...
Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
Documentation/filesystems/ramfs-rootfs-initramfs.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.27-rc9-git2.orig/Documentation/filesystems/ramfs-rootfs-initramfs.txt
+++ linux-2.6.27-rc9-git2/Documentation/filesystems/ramfs-rootfs-initramfs.txt
@@ -263,7 +263,7 @@ User Mode Linux, like so:
sleep(999999999);
}
EOF
- gcc -static hello2.c -o init
+ gcc -static hello.c -o init
echo init | cpio -o -H newc | gzip > test.cpio.gz
# Testing external initramfs using the initrd loading mechanism.
qemu -kernel /boot/vmlinuz -initrd test.cpio.gz /dev/zero
--
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 4/8] docs: fix ManagementStyle book name
2008-10-09 23:52 [PATCH 1/8 for 2.6.27] docs: fix uvesafb mode_option Randy Dunlap
` (3 preceding siblings ...)
2008-10-09 23:52 ` [PATCH 3/8] docs: fix ramfs hello program build name Randy Dunlap
@ 2008-10-09 23:52 ` Randy Dunlap
2008-10-09 23:52 ` [PATCH 7/8] docs: fix Doc/x86/ subdir references Randy Dunlap
2008-10-09 23:52 ` [PATCH 8/8] docs: fix docbook cmd output alignment Randy Dunlap
6 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2008-10-09 23:52 UTC (permalink / raw)
To: linux-kernel
From: Jiri Pirko <jpirko@redhat.com>
Just corrected the book name. I'm probably the only one who ever read
this file :-)
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
Documentation/ManagementStyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.27-rc9-git2.orig/Documentation/ManagementStyle
+++ linux-2.6.27-rc9-git2/Documentation/ManagementStyle
@@ -17,7 +17,7 @@ companies. If you sign purchase orders
budget of your group, you're almost certainly not a kernel manager.
These suggestions may or may not apply to you.
-First off, I'd suggest buying "Seven Habits of Highly Successful
+First off, I'd suggest buying "Seven Habits of Highly Effective
People", and NOT read it. Burn it, it's a great symbolic gesture.
(*) This document does so not so much by answering the question, but by
--
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 7/8] docs: fix Doc/x86/ subdir references
2008-10-09 23:52 [PATCH 1/8 for 2.6.27] docs: fix uvesafb mode_option Randy Dunlap
` (4 preceding siblings ...)
2008-10-09 23:52 ` [PATCH 4/8] docs: fix ManagementStyle book name Randy Dunlap
@ 2008-10-09 23:52 ` Randy Dunlap
2008-10-09 23:52 ` [PATCH 8/8] docs: fix docbook cmd output alignment Randy Dunlap
6 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2008-10-09 23:52 UTC (permalink / raw)
To: linux-kernel
From: Uwe Hermann <uwe@hermann-uwe.de>
The Documentation/i386 and Documentation/x86_64 directories and their
contents have been moved into Documentation/x86. Fix references to
those files accordingly.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
Documentation/00-INDEX | 4 ++--
Documentation/kernel-parameters.txt | 12 ++++++------
Documentation/lguest/lguest.c | 2 +-
Documentation/x86/x86_64/boot-options.txt | 4 ++--
Documentation/x86/x86_64/fake-numa-for-cpusets | 2 +-
5 files changed, 12 insertions(+), 12 deletions(-)
--- linux-2.6.27-rc9-git2.orig/Documentation/00-INDEX
+++ linux-2.6.27-rc9-git2/Documentation/00-INDEX
@@ -171,7 +171,7 @@ i2c/
- directory with info about the I2C bus/protocol (2 wire, kHz speed).
i2o/
- directory with info about the Linux I2O subsystem.
-i386/
+x86/i386/
- directory with info about Linux on Intel 32 bit architecture.
ia64/
- directory with info about Linux on Intel 64 bit architecture.
@@ -383,7 +383,7 @@ w1/
- directory with documents regarding the 1-wire (w1) subsystem.
watchdog/
- how to auto-reboot Linux if it has "fallen and can't get up". ;-)
-x86_64/
+x86/x86_64/
- directory with info on Linux support for AMD x86-64 (Hammer) machines.
zorro.txt
- info on writing drivers for Zorro bus devices found on Amigas.
--- linux-2.6.27-rc9-git2.orig/Documentation/kernel-parameters.txt
+++ linux-2.6.27-rc9-git2/Documentation/kernel-parameters.txt
@@ -100,7 +100,7 @@ parameter is applicable:
X86-32 X86-32, aka i386 architecture is enabled.
X86-64 X86-64 architecture is enabled.
More X86-64 boot options can be found in
- Documentation/x86_64/boot-options.txt .
+ Documentation/x86/x86_64/boot-options.txt .
In addition, the following text indicates that the option:
@@ -111,10 +111,10 @@ In addition, the following text indicate
Parameters denoted with BOOT are actually interpreted by the boot
loader, and have no meaning to the kernel directly.
Do not modify the syntax of boot loader parameters without extreme
-need or coordination with <Documentation/i386/boot.txt>.
+need or coordination with <Documentation/x86/i386/boot.txt>.
There are also arch-specific kernel-parameters not documented here.
-See for example <Documentation/x86_64/boot-options.txt>.
+See for example <Documentation/x86/x86_64/boot-options.txt>.
Note that ALL kernel parameters listed below are CASE SENSITIVE, and that
a trailing = on the name of any parameter states that that parameter will
@@ -1187,7 +1187,7 @@ and is between 256 and 4096 characters.
mce [X86-32] Machine Check Exception
- mce=option [X86-64] See Documentation/x86_64/boot-options.txt
+ mce=option [X86-64] See Documentation/x86/x86_64/boot-options.txt
md= [HW] RAID subsystems devices and level
See Documentation/md.txt.
@@ -1650,7 +1650,7 @@ and is between 256 and 4096 characters.
See Documentation/paride.txt.
pirq= [SMP,APIC] Manual mp-table setup
- See Documentation/i386/IO-APIC.txt.
+ See Documentation/x86/i386/IO-APIC.txt.
plip= [PPT,NET] Parallel port network link
Format: { parport<nr> | timid | 0 }
@@ -2231,7 +2231,7 @@ and is between 256 and 4096 characters.
See Documentation/fb/modedb.txt.
vga= [BOOT,X86-32] Select a particular video mode
- See Documentation/i386/boot.txt and
+ See Documentation/x86/i386/boot.txt and
Documentation/svga.txt.
Use vga=ask for menu.
This is actually a boot loader parameter; the value is
--- linux-2.6.27-rc9-git2.orig/Documentation/lguest/lguest.c
+++ linux-2.6.27-rc9-git2/Documentation/lguest/lguest.c
@@ -402,7 +402,7 @@ static unsigned long load_bzimage(int fd
void *p = from_guest_phys(0x100000);
/* Go back to the start of the file and read the header. It should be
- * a Linux boot header (see Documentation/i386/boot.txt) */
+ * a Linux boot header (see Documentation/x86/i386/boot.txt) */
lseek(fd, 0, SEEK_SET);
read(fd, &boot, sizeof(boot));
--- linux-2.6.27-rc9-git2.orig/Documentation/x86/x86_64/boot-options.txt
+++ linux-2.6.27-rc9-git2/Documentation/x86/x86_64/boot-options.txt
@@ -35,7 +35,7 @@ APICs
nolapic Don't use the local APIC (alias for i386 compatibility)
- pirq=... See Documentation/i386/IO-APIC.txt
+ pirq=... See Documentation/x86/i386/IO-APIC.txt
noapictimer Don't set up the APIC timer
@@ -143,7 +143,7 @@ Non Executable Mappings
SMP
additional_cpus=NUM Allow NUM more CPUs for hotplug
- (defaults are specified by the BIOS, see Documentation/x86_64/cpu-hotplug-spec)
+ (defaults are specified by the BIOS, see Documentation/x86/x86_64/cpu-hotplug-spec)
NUMA
--- linux-2.6.27-rc9-git2.orig/Documentation/x86/x86_64/fake-numa-for-cpusets
+++ linux-2.6.27-rc9-git2/Documentation/x86/x86_64/fake-numa-for-cpusets
@@ -10,7 +10,7 @@ amount of system memory that are availab
For more information on the features of cpusets, see Documentation/cpusets.txt.
There are a number of different configurations you can use for your needs. For
more information on the numa=fake command line option and its various ways of
-configuring fake nodes, see Documentation/x86_64/boot-options.txt.
+configuring fake nodes, see Documentation/x86/x86_64/boot-options.txt.
For the purposes of this introduction, we'll assume a very primitive NUMA
emulation setup of "numa=fake=4*512,". This will split our system memory into
--
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 8/8] docs: fix docbook cmd output alignment
2008-10-09 23:52 [PATCH 1/8 for 2.6.27] docs: fix uvesafb mode_option Randy Dunlap
` (5 preceding siblings ...)
2008-10-09 23:52 ` [PATCH 7/8] docs: fix Doc/x86/ subdir references Randy Dunlap
@ 2008-10-09 23:52 ` Randy Dunlap
6 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2008-10-09 23:52 UTC (permalink / raw)
To: linux-kernel
From: Hans Ulrich Niedermann <hun@n-dimensional.de>
The total width of the command name plus spaces should be
8 characters, but were 7 and 9, respectively. With 8 chars,
all commands are now lining up nicely.
The mandocs, psdocs, xmldocs commands are OK.
Before:
HOSTCC scripts/basic/docproc
DOCPROC Documentation/DocBook/deviceiobook.xml
HTML Documentation/DocBook/deviceiobook.html
DOCPROC Documentation/DocBook/wanbook.xml
PDF Documentation/DocBook/wanbook.pdf
After:
HOSTCC scripts/basic/docproc
DOCPROC Documentation/DocBook/deviceiobook.xml
HTML Documentation/DocBook/deviceiobook.html
DOCPROC Documentation/DocBook/wanbook.xml
PDF Documentation/DocBook/wanbook.pdf
Signed-off-by: Hans Ulrich Niedermann <hun@n-dimensional.de>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
Documentation/DocBook/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.27-rc9-git2.orig/Documentation/DocBook/Makefile
+++ linux-2.6.27-rc9-git2/Documentation/DocBook/Makefile
@@ -136,7 +136,7 @@ quiet_cmd_db2ps = PS $@
%.ps : %.xml
$(call cmd,db2ps)
-quiet_cmd_db2pdf = PDF $@
+quiet_cmd_db2pdf = PDF $@
cmd_db2pdf = $(subst TYPE,pdf, $($(PDF_METHOD)template))
%.pdf : %.xml
$(call cmd,db2pdf)
@@ -148,7 +148,7 @@ build_main_index = rm -rf $(main_idx) &&
echo '<h2>Kernel Version: $(KERNELVERSION)</h2>' >> $(main_idx) && \
cat $(HTML) >> $(main_idx)
-quiet_cmd_db2html = HTML $@
+quiet_cmd_db2html = HTML $@
cmd_db2html = xmlto xhtml $(XMLTOFLAGS) -o $(patsubst %.html,%,$@) $< && \
echo '<a HREF="$(patsubst %.html,%,$(notdir $@))/index.html"> \
$(patsubst %.html,%,$(notdir $@))</a><p>' > $@
--
^ permalink raw reply [flat|nested] 8+ messages in thread