All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH] ASoC: Hide TLV320AIC26 configuration option for non-OpenFirwmare users
Date: Mon, 13 Oct 2008 17:38:34 +0100	[thread overview]
Message-ID: <1223915914-12196-1-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)

Since Kconfig ignores dependencies on select and other users should
select SND_SOC_TLV320AIC26 we can add a dependency on the OpenFirmware
helper to avoid exposing the menu entry to users who can't benefit from
it.

Thanks to Takashi for the suggestion.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/Kconfig |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 4975d85..9242889 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -70,6 +70,9 @@ config SND_SOC_TLV320AIC23
 config SND_SOC_TLV320AIC26
 	tristate "TI TLV320AIC26 Codec support"
 	depends on SPI
+	# Note the Kconfig doesn't enforce dependencies - this just
+	# prevents non-OF users seeing the tristate in menus.
+	depends on SND_SOC_OF_SIMPLE
 
 config SND_SOC_TLV320AIC3X
 	tristate
-- 
1.5.6.5

             reply	other threads:[~2008-10-13 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13 16:38 Mark Brown [this message]
2008-10-13 17:33 ` [PATCH] ASoC: Hide TLV320AIC26 configuration option for non-OpenFirwmare users Takashi Iwai
2008-10-13 18:14   ` Mark Brown
2008-10-13 18:16     ` Mark Brown
2008-10-14  5:45       ` Takashi Iwai
2008-10-14  5:47     ` Takashi Iwai
2008-10-14  9:04       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223915914-12196-1-git-send-email-broonie@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.