From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Hide TLV320AIC26 configuration option for non-OpenFirwmare users
Date: Mon, 13 Oct 2008 19:14:58 +0100 [thread overview]
Message-ID: <20081013181458.GA23014@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5h1vykv1rm.wl%tiwai@suse.de>
On Mon, Oct 13, 2008 at 07:33:01PM +0200, Takashi Iwai wrote:
> Hmm, I'm afraid this may disable CONFIG_SND_SOC_TLV320AIC26 when
> CONFIG_SND_SOC_OF_SIMPLE=n automatically, no?
Yes, I'd feared that too but it doesn't do that, at least not in my
testing - the dependencies are just completely ignored.
> > Thanks to Takashi for the suggestion.
> Actually I proposed a wrong solution. What I meant was the form using
> "if" instead of "depends on":
> config SND_SOC_TLV320AIC26
> tristate "TI TLV320AIC26 Codec support" if SND_SOC_OF_SIMPLE
> ...
> In this way, the selectable item appears only when
> CONFIG_SND_SOC_OF_SIMPLE is set. The other dependencies remain as
> they are.
Ah, yes. That seems to work too and is a bit neater, though still a bit
nasty since it looks like the tristate is conditional on the
OpenFirmware support now so it's still not entirely clear that the right
thing will happen. Updated patch coming in a moment.
next prev parent reply other threads:[~2008-10-13 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 16:38 [PATCH] ASoC: Hide TLV320AIC26 configuration option for non-OpenFirwmare users Mark Brown
2008-10-13 17:33 ` Takashi Iwai
2008-10-13 18:14 ` Mark Brown [this message]
2008-10-13 18:16 ` Mark Brown
2008-10-14 5:45 ` Takashi Iwai
2008-10-14 5:47 ` Takashi Iwai
2008-10-14 9:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013181458.GA23014@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.