All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: kvm@vger.kernel.org
Cc: joro@8bytes.org, anthony@codemonkey.ws, avi@redhat.com
Subject: [PATCH 2/9] Add helper functions for nested SVM v5
Date: Mon, 20 Oct 2008 19:04:43 +0200	[thread overview]
Message-ID: <1224522290-11740-3-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1224522290-11740-2-git-send-email-agraf@suse.de>

These are helpers for the nested SVM implementation.

- nsvm_printk implements a debug printk variant
- nested_svm_do calls a handler that can accesses gpa-based memory

v3 makes use of the new permission checker

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/x86/kvm/svm.c |   88 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 88 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 4ee5376..a00421b 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -48,6 +48,16 @@ MODULE_LICENSE("GPL");
 
 #define DEBUGCTL_RESERVED_BITS (~(0x3fULL))
 
+/* Turn on to get debugging output*/
+/* #define NESTED_DEBUG */
+
+#ifdef NESTED_DEBUG
+#define nsvm_printk(fmt, args...) printk(KERN_INFO fmt, ## args)
+#else
+static inline void nsvm_printk(char *fmt, ...) {
+}
+#endif
+
 /* enable NPT for AMD64 and X86 with PAE */
 #if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
 static bool npt_enabled = true;
@@ -1145,6 +1155,84 @@ static int vmmcall_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run)
 	return 1;
 }
 
+static int nested_svm_check_permissions(struct vcpu_svm *svm)
+{
+	if (svm->vmcb->save.cpl) {
+		printk(KERN_ERR "%s: invalid cpl 0x%x at ip 0x%lx\n",
+		       __func__, svm->vmcb->save.cpl, kvm_rip_read(&svm->vcpu));
+		kvm_queue_exception(&svm->vcpu, GP_VECTOR);
+		return 1;
+	}
+
+       if (!(svm->vcpu.arch.shadow_efer & MSR_EFER_SVME_MASK)
+           || !is_paging(&svm->vcpu)) {
+               kvm_queue_exception(&svm->vcpu, UD_VECTOR);
+               return 1;
+       }
+
+       return 0;
+}
+
+static struct page *nested_svm_get_page(struct vcpu_svm *svm, u64 gpa)
+{
+	struct page *page;
+
+	down_read(&current->mm->mmap_sem);
+	page = gfn_to_page(svm->vcpu.kvm, gpa >> PAGE_SHIFT);
+	up_read(&current->mm->mmap_sem);
+
+	if (is_error_page(page)) {
+		printk(KERN_ERR "%s: could not find page at 0x%llx\n",
+		       __func__, gpa);
+		kvm_release_page_clean(page);
+		kvm_queue_exception(&svm->vcpu, GP_VECTOR);
+		return NULL;
+	}
+	return page;
+}
+
+static int nested_svm_do(struct vcpu_svm *svm,
+			 u64 arg1_gpa, u64 arg2_gpa, void *opaque,
+			 int (*handler)(struct vcpu_svm *svm,
+					void *arg1,
+					void *arg2,
+					void *opaque))
+{
+	struct page *arg1_page;
+	struct page *arg2_page = NULL;
+	void *arg1;
+	void *arg2 = NULL;
+	int retval;
+
+	arg1_page = nested_svm_get_page(svm, arg1_gpa);
+	if(arg1_page == NULL)
+		return 1;
+
+	if (arg2_gpa) {
+		arg2_page = nested_svm_get_page(svm, arg2_gpa);
+		if(arg2_page == NULL) {
+			kvm_release_page_clean(arg1_page);
+			return 1;
+		}
+	}
+
+	arg1 = kmap_atomic(arg1_page, KM_USER0);
+	if (arg2_gpa)
+		arg2 = kmap_atomic(arg2_page, KM_USER1);
+
+	retval = handler(svm, arg1, arg2, opaque);
+
+	kunmap_atomic(arg1, KM_USER0);
+	if (arg2_gpa)
+		kunmap_atomic(arg2, KM_USER1);
+
+	kvm_release_page_dirty(arg1_page);
+	if (arg2_gpa)
+		kvm_release_page_dirty(arg2_page);
+
+	return retval;
+}
+
 static int invalid_op_interception(struct vcpu_svm *svm,
 				   struct kvm_run *kvm_run)
 {
-- 
1.5.6


  reply	other threads:[~2008-10-20 17:04 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20 17:04 [PATCH 0/9] Add support for nested SVM (kernel) v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 1/9] Clean up VINTR setting v5 Alexander Graf
2008-10-20 17:04   ` Alexander Graf [this message]
2008-10-20 17:04     ` [PATCH 3/9] Implement GIF, clgi and stgi v5 Alexander Graf
2008-10-20 17:04       ` [PATCH 4/9] Implement hsave v5 Alexander Graf
2008-10-20 17:04         ` [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5 Alexander Graf
2008-10-20 17:04           ` [PATCH 6/9] Add VMRUN handler v5 Alexander Graf
2008-10-20 17:04             ` [PATCH 7/9] Add VMEXIT handler and intercepts v5 Alexander Graf
2008-10-20 17:04               ` [PATCH 8/9] allow read access to MSR_VM_VR Alexander Graf
2008-10-20 17:04                 ` [PATCH 9/9] Allow setting the SVME bit v5 Alexander Graf
2008-10-29 13:58                   ` Joerg Roedel
2008-10-29 14:03                     ` Alexander Graf
2008-10-29 14:17                       ` Avi Kivity
2008-10-29 14:07                     ` Avi Kivity
2008-10-30 19:16                   ` Anthony Liguori
2008-10-30 19:24                     ` Avi Kivity
2008-10-30 20:46                       ` Alexander Graf
2008-10-30 20:44                     ` Alexander Graf
2008-10-30 20:52                       ` Anthony Liguori
2008-11-02  9:11                         ` Avi Kivity
2008-11-03  7:37                           ` Alexander Graf
2008-11-03 13:54                             ` Avi Kivity
2008-10-30 19:15                 ` [PATCH 8/9] allow read access to MSR_VM_VR Anthony Liguori
2008-10-31 10:57                   ` Joerg Roedel
2008-10-28 18:38             ` Add VMRUN handler v5 Mike Day
2008-10-29  5:35               ` Alexander Graf
2008-11-18 14:14             ` [PATCH 6/9] " Muli Ben-Yehuda
2008-10-30 18:06           ` [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5 Anthony Liguori
2008-10-30 18:44             ` Alexander Graf
2008-10-30 19:14               ` Anthony Liguori
2008-10-30 21:02                 ` Alexander Graf
2008-10-30 21:38                   ` Anthony Liguori
2008-10-30 18:04         ` [PATCH 4/9] Implement hsave v5 Anthony Liguori
2008-10-30 18:43           ` Alexander Graf
2008-10-30 19:05             ` Anthony Liguori
2008-10-30 19:29             ` Avi Kivity
2008-10-30 20:38               ` Alexander Graf
2008-10-30 20:44                 ` Anthony Liguori
2008-10-30 20:47                   ` Alexander Graf
2008-10-30 22:05                     ` Anthony Liguori
2008-11-02  9:24                 ` Avi Kivity
2008-10-27 19:09       ` Implement GIF, clgi and stgi v5 Mike Day
2008-10-27 19:29         ` Avi Kivity
2008-10-27 19:40           ` Mike Day
2008-10-30 18:02       ` [PATCH 3/9] " Anthony Liguori
2008-10-30 18:10         ` Avi Kivity
2008-10-30 18:35           ` Alexander Graf
2008-10-30 19:08             ` Anthony Liguori
2008-10-30 19:11           ` Anthony Liguori
2008-10-29 13:48     ` [PATCH 2/9] Add helper functions for nested SVM v5 Joerg Roedel
2008-10-30 17:56     ` Anthony Liguori
2008-10-30 18:41       ` Alexander Graf
2008-10-30 19:10         ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224522290-11740-3-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.