All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: kvm@vger.kernel.org
Cc: joro@8bytes.org, anthony@codemonkey.ws, avi@redhat.com
Subject: [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5
Date: Mon, 20 Oct 2008 19:04:46 +0200	[thread overview]
Message-ID: <1224522290-11740-6-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1224522290-11740-5-git-send-email-agraf@suse.de>

This implements the VMLOAD and VMSAVE instructions, that usually surround
the VMRUN instructions. Both instructions load / restore the same elements,
so we only need to implement them once.

v2 fixes CPL checking and replaces memcpy by assignments
v3 makes use of the new permission checking

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/x86/kvm/svm.c |   60 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 58 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index eb301fe..10ad02b 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -1242,6 +1242,62 @@ static int nested_svm_do(struct vcpu_svm *svm,
 	return retval;
 }
 
+static int nested_svm_vmloadsave(struct vmcb *from_vmcb, struct vmcb *to_vmcb)
+{
+	to_vmcb->save.fs = from_vmcb->save.fs;
+	to_vmcb->save.gs = from_vmcb->save.gs;
+	to_vmcb->save.tr = from_vmcb->save.tr;
+	to_vmcb->save.ldtr = from_vmcb->save.ldtr;
+	to_vmcb->save.kernel_gs_base = from_vmcb->save.kernel_gs_base;
+	to_vmcb->save.star = from_vmcb->save.star;
+	to_vmcb->save.lstar = from_vmcb->save.lstar;
+	to_vmcb->save.cstar = from_vmcb->save.cstar;
+	to_vmcb->save.sfmask = from_vmcb->save.sfmask;
+	to_vmcb->save.sysenter_cs = from_vmcb->save.sysenter_cs;
+	to_vmcb->save.sysenter_esp = from_vmcb->save.sysenter_esp;
+	to_vmcb->save.sysenter_eip = from_vmcb->save.sysenter_eip;
+
+	return 1;
+}
+
+static int nested_svm_vmload(struct vcpu_svm *svm, void *nested_vmcb,
+			     void *arg2, void *opaque)
+{
+	return nested_svm_vmloadsave((struct vmcb *)nested_vmcb, svm->vmcb);
+}
+
+static int nested_svm_vmsave(struct vcpu_svm *svm, void *nested_vmcb,
+			     void *arg2, void *opaque)
+{
+	return nested_svm_vmloadsave(svm->vmcb, (struct vmcb *)nested_vmcb);
+}
+
+static int vmload_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run)
+{
+	if (nested_svm_check_permissions(svm))
+		return 1;
+
+	svm->next_rip = kvm_rip_read(&svm->vcpu) + 3;
+	skip_emulated_instruction(&svm->vcpu);
+
+	nested_svm_do(svm, svm->vmcb->save.rax, 0, NULL, nested_svm_vmload);
+
+	return 1;
+}
+
+static int vmsave_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run)
+{
+	if (nested_svm_check_permissions(svm))
+		return 1;
+
+	svm->next_rip = kvm_rip_read(&svm->vcpu) + 3;
+	skip_emulated_instruction(&svm->vcpu);
+
+	nested_svm_do(svm, svm->vmcb->save.rax, 0, NULL, nested_svm_vmsave);
+
+	return 1;
+}
+
 static int stgi_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run)
 {
 	if (nested_svm_check_permissions(svm))
@@ -1576,8 +1632,8 @@ static int (*svm_exit_handlers[])(struct vcpu_svm *svm,
 	[SVM_EXIT_SHUTDOWN]			= shutdown_interception,
 	[SVM_EXIT_VMRUN]			= invalid_op_interception,
 	[SVM_EXIT_VMMCALL]			= vmmcall_interception,
-	[SVM_EXIT_VMLOAD]			= invalid_op_interception,
-	[SVM_EXIT_VMSAVE]			= invalid_op_interception,
+	[SVM_EXIT_VMLOAD]			= vmload_interception,
+	[SVM_EXIT_VMSAVE]			= vmsave_interception,
 	[SVM_EXIT_STGI]				= stgi_interception,
 	[SVM_EXIT_CLGI]				= clgi_interception,
 	[SVM_EXIT_SKINIT]			= invalid_op_interception,
-- 
1.5.6


  reply	other threads:[~2008-10-20 17:04 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20 17:04 [PATCH 0/9] Add support for nested SVM (kernel) v5 Alexander Graf
2008-10-20 17:04 ` [PATCH 1/9] Clean up VINTR setting v5 Alexander Graf
2008-10-20 17:04   ` [PATCH 2/9] Add helper functions for nested SVM v5 Alexander Graf
2008-10-20 17:04     ` [PATCH 3/9] Implement GIF, clgi and stgi v5 Alexander Graf
2008-10-20 17:04       ` [PATCH 4/9] Implement hsave v5 Alexander Graf
2008-10-20 17:04         ` Alexander Graf [this message]
2008-10-20 17:04           ` [PATCH 6/9] Add VMRUN handler v5 Alexander Graf
2008-10-20 17:04             ` [PATCH 7/9] Add VMEXIT handler and intercepts v5 Alexander Graf
2008-10-20 17:04               ` [PATCH 8/9] allow read access to MSR_VM_VR Alexander Graf
2008-10-20 17:04                 ` [PATCH 9/9] Allow setting the SVME bit v5 Alexander Graf
2008-10-29 13:58                   ` Joerg Roedel
2008-10-29 14:03                     ` Alexander Graf
2008-10-29 14:17                       ` Avi Kivity
2008-10-29 14:07                     ` Avi Kivity
2008-10-30 19:16                   ` Anthony Liguori
2008-10-30 19:24                     ` Avi Kivity
2008-10-30 20:46                       ` Alexander Graf
2008-10-30 20:44                     ` Alexander Graf
2008-10-30 20:52                       ` Anthony Liguori
2008-11-02  9:11                         ` Avi Kivity
2008-11-03  7:37                           ` Alexander Graf
2008-11-03 13:54                             ` Avi Kivity
2008-10-30 19:15                 ` [PATCH 8/9] allow read access to MSR_VM_VR Anthony Liguori
2008-10-31 10:57                   ` Joerg Roedel
2008-10-28 18:38             ` Add VMRUN handler v5 Mike Day
2008-10-29  5:35               ` Alexander Graf
2008-11-18 14:14             ` [PATCH 6/9] " Muli Ben-Yehuda
2008-10-30 18:06           ` [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5 Anthony Liguori
2008-10-30 18:44             ` Alexander Graf
2008-10-30 19:14               ` Anthony Liguori
2008-10-30 21:02                 ` Alexander Graf
2008-10-30 21:38                   ` Anthony Liguori
2008-10-30 18:04         ` [PATCH 4/9] Implement hsave v5 Anthony Liguori
2008-10-30 18:43           ` Alexander Graf
2008-10-30 19:05             ` Anthony Liguori
2008-10-30 19:29             ` Avi Kivity
2008-10-30 20:38               ` Alexander Graf
2008-10-30 20:44                 ` Anthony Liguori
2008-10-30 20:47                   ` Alexander Graf
2008-10-30 22:05                     ` Anthony Liguori
2008-11-02  9:24                 ` Avi Kivity
2008-10-27 19:09       ` Implement GIF, clgi and stgi v5 Mike Day
2008-10-27 19:29         ` Avi Kivity
2008-10-27 19:40           ` Mike Day
2008-10-30 18:02       ` [PATCH 3/9] " Anthony Liguori
2008-10-30 18:10         ` Avi Kivity
2008-10-30 18:35           ` Alexander Graf
2008-10-30 19:08             ` Anthony Liguori
2008-10-30 19:11           ` Anthony Liguori
2008-10-29 13:48     ` [PATCH 2/9] Add helper functions for nested SVM v5 Joerg Roedel
2008-10-30 17:56     ` Anthony Liguori
2008-10-30 18:41       ` Alexander Graf
2008-10-30 19:10         ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224522290-11740-6-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.