All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, torvalds@osdl.org, maxk@qualcomm.com,
	tglx@linutronix.de
Subject: Re: [PATCH] genirq: Set initial default irq affinity to just CPU0
Date: Sun, 26 Oct 2008 08:33:09 +1100	[thread overview]
Message-ID: <1224970389.7654.473.camel@pasglop> (raw)
In-Reply-To: <20081024.161813.193686281.davem@davemloft.net>

On Fri, 2008-10-24 at 16:18 -0700, David Miller wrote:
> From: Kumar Gala <galak@kernel.crashing.org>
> Date: Fri, 24 Oct 2008 10:57:38 -0500
> 
> > Commit 18404756765c713a0be4eb1082920c04822ce588 introduced a regression
> > on a subset of SMP based PPC systems whose interrupt controller only
> > allow setting an irq to a single processor.  The previous behavior
> > was only CPU0 was initially setup to get interrupts.  Revert back
> > to that behavior.
> > 
> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> 
> I really don't remember getting all of my interrupts only on cpu 0
> on sparc64 before any of these changes.  I therefore find all of
> this quite mysterious. :-)

Well, I don't know how you do it but on powerpc, we explicitely fill the
affinity masks at boot time when we can spread interrupts... Maybe we
should change it the other way around and limit the mask when we can't ?
It's hard to tell for sure at this stage.

Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: galak@kernel.crashing.org, akpm@osdl.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	torvalds@osdl.org, maxk@qualcomm.com, tglx@linutronix.de
Subject: Re: [PATCH] genirq: Set initial default irq affinity to just CPU0
Date: Sun, 26 Oct 2008 08:33:09 +1100	[thread overview]
Message-ID: <1224970389.7654.473.camel@pasglop> (raw)
In-Reply-To: <20081024.161813.193686281.davem@davemloft.net>

On Fri, 2008-10-24 at 16:18 -0700, David Miller wrote:
> From: Kumar Gala <galak@kernel.crashing.org>
> Date: Fri, 24 Oct 2008 10:57:38 -0500
> 
> > Commit 18404756765c713a0be4eb1082920c04822ce588 introduced a regression
> > on a subset of SMP based PPC systems whose interrupt controller only
> > allow setting an irq to a single processor.  The previous behavior
> > was only CPU0 was initially setup to get interrupts.  Revert back
> > to that behavior.
> > 
> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> 
> I really don't remember getting all of my interrupts only on cpu 0
> on sparc64 before any of these changes.  I therefore find all of
> this quite mysterious. :-)

Well, I don't know how you do it but on powerpc, we explicitely fill the
affinity masks at boot time when we can spread interrupts... Maybe we
should change it the other way around and limit the mask when we can't ?
It's hard to tell for sure at this stage.

Ben.



  reply	other threads:[~2008-10-25 21:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 15:57 [PATCH] genirq: Set initial default irq affinity to just CPU0 Kumar Gala
2008-10-24 15:57 ` Kumar Gala
2008-10-24 23:18 ` David Miller
2008-10-24 23:18   ` David Miller
2008-10-25 21:33   ` Benjamin Herrenschmidt [this message]
2008-10-25 21:33     ` Benjamin Herrenschmidt
2008-10-25 22:53     ` Kevin Diggs
2008-10-26  4:05       ` David Miller
2008-10-27 17:36         ` Chris Friesen
2008-10-27 18:28           ` David Miller
2008-10-27 19:10             ` Chris Friesen
2008-10-27 19:25               ` David Miller
2008-10-28  3:46                 ` Chris Friesen
2008-10-27 19:43             ` Kumar Gala
2008-10-27 19:49               ` David Miller
2008-10-27 20:46                 ` Kumar Gala
2008-10-26  6:48       ` Benjamin Herrenschmidt
2008-10-26  7:16         ` David Miller
2008-10-26  8:29           ` Benjamin Herrenschmidt
2008-10-27  2:30         ` Kevin Diggs
2008-10-27  2:49           ` Benjamin Herrenschmidt
2008-10-26  4:04     ` David Miller
2008-10-26  4:04       ` David Miller
2008-10-26  6:33       ` Benjamin Herrenschmidt
2008-10-26  6:33         ` Benjamin Herrenschmidt
2008-10-27 13:43         ` Kumar Gala
2008-10-27 13:43           ` Kumar Gala
2008-10-27 20:27           ` Benjamin Herrenschmidt
2008-10-27 20:27             ` Benjamin Herrenschmidt
2008-10-27 20:45             ` Kumar Gala
2008-10-27 20:45               ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224970389.7654.473.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=maxk@qualcomm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.