All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@kernel.org>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Eric Miao <eric.y.miao@gmail.com>,
	Jonathan Cameron <Jonathan.Cameron@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] da903x regulator bug fix
Date: Tue, 28 Oct 2008 11:19:38 +0000	[thread overview]
Message-ID: <1225192778.28382.137.camel@dell-desktop.example.com> (raw)
In-Reply-To: <4906F194.30901@cam.ac.uk>

On Tue, 2008-10-28 at 11:03 +0000, Jonathan Cameron wrote:
> Changes the device registration part of the probe function to supply the
> regulator device rather than its parent (the mfd device) as this caused
> problems when the regulator core attempted to find constraints associated
> with the regulators.
> 
> Signed-of-by: Jonathan Cameron <jic23@cam.ac.uk>

Thanks, this is more preferable than the first patch. I would ultimately
prefer this regulator to be more like wm8350 in terms of mfd
registration but we are in rc2 so this will have to wait.

Eric, would you like to Ack ?

Thanks

Liam



  reply	other threads:[~2008-10-28 11:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 15:47 Da903x regulator driver. Bug? Jonathan Cameron
2008-10-24 17:23 ` Jonathan Cameron
2008-10-24 18:24   ` Liam Girdwood
2008-10-24 18:53     ` Jonathan Cameron
2008-10-24 19:44       ` Mark Brown
2008-10-27 15:29 ` [PATCH] da903x regulator bug fix Jonathan Cameron
2008-10-28  1:01   ` Eric Miao
2008-10-28  1:02     ` Eric Miao
2008-10-28 10:40       ` Jonathan Cameron
2008-10-28 11:03       ` Jonathan Cameron
2008-10-28 11:19         ` Liam Girdwood [this message]
2008-10-28 12:21           ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225192778.28382.137.camel@dell-desktop.example.com \
    --to=lrg@kernel.org \
    --cc=Jonathan.Cameron@gmail.com \
    --cc=eric.y.miao@gmail.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.