From: Mark McLoughlin <markmc@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] virtio_net: don't set NETIF_F_FRAGLIST
Date: Thu, 06 Nov 2008 10:10:29 +0000 [thread overview]
Message-ID: <1225966229.7284.2.camel@blaa> (raw)
In-Reply-To: <200811060853.11566.rusty@rustcorp.com.au>
On Thu, 2008-11-06 at 08:53 +1100, Rusty Russell wrote:
> On Wednesday 05 November 2008 23:34:46 Mark McLoughlin wrote:
> > We don't handle skb_shared_info->frag_list, so we shouldn't
> > be setting the NETIF_F_FRAGLIST flag.
>
> We don't?
>
> skb_to_sgvec() should handle it OK, is there some subtlety I'm missing?
Good grief ... yes, sorry.
Same is true for the tun patch, but I wonder ... could a fraglist skb
exceed 64k? i.e. we need to know the max possible size of a packet
before reading it from the tap.
Cheers,
Mark.
next prev parent reply other threads:[~2008-11-06 10:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 12:34 [PATCH] virtio_net: don't set NETIF_F_FRAGLIST Mark McLoughlin
2008-11-05 21:53 ` Rusty Russell
2008-11-06 10:10 ` Mark McLoughlin [this message]
2008-11-06 5:43 ` Jeff Garzik
2008-11-06 10:12 ` Mark McLoughlin
2008-11-06 10:48 ` Jeff Garzik
2008-11-06 10:56 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225966229.7284.2.camel@blaa \
--to=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.