All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: unlisted-recipients:; (no To-header on input)
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	netdev@vger.kernel.org, Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH] virtio_net: don't set NETIF_F_FRAGLIST
Date: Thu, 06 Nov 2008 00:43:22 -0500	[thread overview]
Message-ID: <491283FA.1020404@garzik.org> (raw)
In-Reply-To: <1225888486-977-1-git-send-email-markmc@redhat.com>

Mark McLoughlin wrote:
> We don't handle skb_shared_info->frag_list, so we shouldn't
> be setting the NETIF_F_FRAGLIST flag.
> 
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
> ---
>  drivers/net/virtio_net.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 0196a0d..9d4fdad 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -505,7 +505,7 @@ static int virtnet_probe(struct virtio_device *vdev)
>  	/* Do we support "hardware" checksums? */
>  	if (csum && virtio_has_feature(vdev, VIRTIO_NET_F_CSUM)) {
>  		/* This opens up the world of extra features. */
> -		dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
> +		dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG;
>  		if (gso && virtio_has_feature(vdev, VIRTIO_NET_F_GSO)) {
>  			dev->features |= NETIF_F_TSO | NETIF_F_UFO
>  				| NETIF_F_TSO_ECN | NETIF_F_TSO6;

applied this and tun patch


  parent reply	other threads:[~2008-11-06  5:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05 12:34 [PATCH] virtio_net: don't set NETIF_F_FRAGLIST Mark McLoughlin
2008-11-05 21:53 ` Rusty Russell
2008-11-06 10:10   ` Mark McLoughlin
2008-11-06  5:43 ` Jeff Garzik [this message]
2008-11-06 10:12   ` Mark McLoughlin
2008-11-06 10:48     ` Jeff Garzik
2008-11-06 10:56       ` Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491283FA.1020404@garzik.org \
    --to=jeff@garzik.org \
    --cc=markmc@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.