All of lore.kernel.org
 help / color / mirror / Atom feed
From: hermann pitton <hermann-pitton@arcor.de>
To: Ricardo Cerqueira <v4l@cerqueira.org>, Roman <muzungu@gmx.net>
Cc: video4linux-list@redhat.com
Subject: Re: Pinnacle PCTV 310i Remote: i2c 'ERROR: NO_DEVICE'
Date: Fri, 07 Nov 2008 01:07:08 +0100	[thread overview]
Message-ID: <1226016428.19661.24.camel@pc10.localdom.local> (raw)
In-Reply-To: <1225936613.3602.24.camel@pc10.localdom.local>

Hi,

Am Donnerstag, den 06.11.2008, 02:56 +0100 schrieb hermann pitton:
> Hi Ricardo,
> 
> Am Donnerstag, den 06.11.2008, 00:46 +0000 schrieb Ricardo Cerqueira:
> > Hi all;
> > 
> > On Thu, 2008-11-06 at 01:09 +0100, hermann pitton wrote:
> > > Hi Matteo,
> > > 
> > > Am Dienstag, den 04.11.2008, 15:09 +0100 schrieb picciuX:
> > > > 2008/11/2 hermann pitton <hermann-pitton@arcor.de>:
> > > > 
> > > > > don't have that remote, but also enable ir-kbd-i2c debug=1.
> > > > >
> > > > > ir-kbd-i2c: probe 0x7a @ saa7133[0]: no
> > > > > ir-kbd-i2c: probe 0x47 @ saa7133[0]: no
> > > > > ir-kbd-i2c: probe 0x71 @ saa7133[0]: no
> > > > > ir-kbd-i2c: probe 0x2d @ saa7133[0]: no
> > > > > ir-kbd-i2c: probe 0x7a @ saa7133[1]: no
> > > > > ir-kbd-i2c: probe 0x47 @ saa7133[1]: no
> > > > > ir-kbd-i2c: probe 0x71 @ saa7133[1]: no
> > > > > ir-kbd-i2c: probe 0x2d @ saa7133[1]: no
> > > > >
> > 
> > 
> > Sorry, I missed the rest of the thread;
> > 
> > In any case, from the above paste, it looks as if you have 2 saa713x
> > boards in the system, right?
> 
> sorry, that was me to illustrate how the difference should look like.
> Must be taken from the quadro md8800 machine.
> 
> I'm playing around with some other requests concerning remote behaviors,
> but have to admit that getting some old PCs running on recent again is
> not that much fun and I'm slow.
> 
> We have a case, where Asus stuff is not reliable on PCI subsystem IDs.
> We can detect the different cards by a difference in the eeprom readout,
> but this needs running i2c on saa7134 init2.
> 
> However, since input_init is on saa7134 init1, we fail here being too
> late. Maybe we should have input init on saa7134 init2 in saa7134-core.
> Roman with such a card mailed to me about that. At least I should be
> close to be able to test it, but no i2c remote stuff is here.

sorry, it is a little OT and only this P7131 Analog card is affected,
which needs to be eeprom detected to work around a duplicate PCI
subsystem for physically different cards.

The wrongly detected card has an USB remote by the way, so in case of
auto detection it will come up without working Asus PC-39 IRQ remote.
If the card number is forced, the remote will work too.

Roman seems to suggest a patch, which basically boils down to this.

diff -r b45ffc93fb82 linux/drivers/media/video/saa7134/saa7134-cards.c
--- a/linux/drivers/media/video/saa7134/saa7134-cards.c	Wed Nov 05 00:59:37 2008 +0000
+++ b/linux/drivers/media/video/saa7134/saa7134-cards.c	Mon Nov 03 16:52:17 2008 +0100
@@ -6307,6 +6307,7 @@ int saa7134_board_init2(struct saa7134_d
 		       printk(KERN_INFO "%s: P7131 analog only, using "
 						       "entry of %s\n",
 		       dev->name, saa7134_boards[dev->board].name);
+		       dev->has_remote = SAA7134_REMOTE_GPIO;
 	       }
 	       break;
 	case SAA7134_BOARD_HAUPPAUGE_HVR1110:
diff -r b45ffc93fb82 linux/drivers/media/video/saa7134/saa7134-core.c
--- a/linux/drivers/media/video/saa7134/saa7134-core.c	Wed Nov 05 00:59:37 2008 +0000
+++ b/linux/drivers/media/video/saa7134/saa7134-core.c	Mon Nov 03 16:44:54 2008 +0100
@@ -729,7 +729,6 @@ static int saa7134_hwinit1(struct saa713
 	saa7134_vbi_init1(dev);
 	if (card_has_mpeg(dev))
 		saa7134_ts_init1(dev);
-	saa7134_input_init1(dev);
 
 	saa7134_hw_enable1(dev);
 
@@ -775,6 +774,7 @@ static int saa7134_hwinit2(struct saa713
 
 	dprintk("hwinit2\n");
 
+	saa7134_input_init1(dev);
 	saa7134_video_init2(dev);
 	saa7134_tvaudio_init2(dev);
 
This seems to work for him and also no trouble on a normal gpio remote,
but I can't test on saa7134 i2c remotes.

Since this is only for that one card for now and the trouble seems to be
caused by the manufacturer, maybe to print use card=number to get also
the remote up would be sufficient, but I post it here just in case we'll
get more of this in the future.

Cheers,
Hermann

> > I suspect the bug is somehow related to that (ir-kbd-i2c is getting the
> > events, but sending them to the wrong board). Have you tried removing
> > one of them?
> 
> Maybe the card is even flaky in the PCI slot, that's why a second
> confirmation would be nice.
> 
> Thanks,
> Hermann
> 
> > --
> > RC
> > > > > You should have the device found at 0x47.
> > > > >
> > > > 
> > > > In fact i see:
> > > > 
> > > > ir-kbd-i2c: probe 0x47 @ saa7133[0]: yes
> > > > 
> > > > So everything seemed to go well. But, same story for the rest: ERROR:
> > > > NO_DEVICE when i press buttons on the remote.
> > > > What seems strange to me is the fact that the driver *reacts* to
> > > > remote key presses, but reacts with an error.
> > > > 
> > > > Cheers
> > > > Matteo
> > > > 
> > > 
> > > since you reported the trouble was already visible for you on earlier
> > > kernels, we might try to get a second confirmation at first.
> > > 
> > > Anyone out there? I'm sending a copy to Ricardo too, who added the
> > > support, not sure if he currently has time to read the list.
> > > 
> > > Cheers,
> > > Hermann
> > > 
> 


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-11-07  0:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31  9:31 Pinnacle PCTV 310i Remote: i2c 'ERROR: NO_DEVICE' picciuX
2008-11-02  0:42 ` hermann pitton
2008-11-04 14:09   ` picciuX
2008-11-06  0:09     ` hermann pitton
2008-11-06  0:46       ` Ricardo Cerqueira
2008-11-06  1:56         ` hermann pitton
2008-11-07  0:07           ` hermann pitton [this message]
2008-11-07 13:46             ` picciuX
2008-11-10 15:41               ` picciuX
2008-11-11  2:09                 ` hermann pitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226016428.19661.24.camel@pc10.localdom.local \
    --to=hermann-pitton@arcor.de \
    --cc=muzungu@gmx.net \
    --cc=v4l@cerqueira.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.