From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Linus Torvalds <torvalds@osdl.org>,
tglx@linutronix.de
Subject: Re: [PATCH 1/1] irq: Maintain user set affinity
Date: Sun, 09 Nov 2008 13:17:39 +1100 [thread overview]
Message-ID: <1226197059.13603.92.camel@pasglop> (raw)
In-Reply-To: <86802c440811081601w2be45e55hc400095137831b85@mail.gmail.com>
> for MSI, affinity is set two times.
>
> also in dynamic_irq_init is setting with
> #ifdef CONFIG_SMP
> cpus_setall(desc->affinity);
> #endif
>
> it seems should use irq_default_affinity instead of CPU_MASK_ALL directly there.
That sounds more like it.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Kumar Gala <galak@kernel.crashing.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/1] irq: Maintain user set affinity
Date: Sun, 09 Nov 2008 13:17:39 +1100 [thread overview]
Message-ID: <1226197059.13603.92.camel@pasglop> (raw)
In-Reply-To: <86802c440811081601w2be45e55hc400095137831b85@mail.gmail.com>
> for MSI, affinity is set two times.
>
> also in dynamic_irq_init is setting with
> #ifdef CONFIG_SMP
> cpus_setall(desc->affinity);
> #endif
>
> it seems should use irq_default_affinity instead of CPU_MASK_ALL directly there.
That sounds more like it.
Cheers,
Ben.
next prev parent reply other threads:[~2008-11-09 2:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 16:31 [PATCH 1/1] irq: Maintain user set affinity Kumar Gala
2008-11-04 16:31 ` Kumar Gala
2008-11-06 21:35 ` Andrew Morton
2008-11-06 21:35 ` Andrew Morton
2008-11-06 23:23 ` Kumar Gala
2008-11-06 23:23 ` Kumar Gala
2008-11-08 22:13 ` Yinghai Lu
2008-11-08 22:13 ` Yinghai Lu
2008-11-08 22:12 ` Yinghai Lu
2008-11-08 22:12 ` Yinghai Lu
2008-11-08 22:17 ` Benjamin Herrenschmidt
2008-11-08 22:17 ` Benjamin Herrenschmidt
2008-11-09 0:01 ` Yinghai Lu
2008-11-09 0:01 ` Yinghai Lu
2008-11-09 2:17 ` Benjamin Herrenschmidt [this message]
2008-11-09 2:17 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226197059.13603.92.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.