From: Michael Ellerman <michael@ellerman.id.au>
To: Jan Beulich <jbeulich@novell.com>
Cc: linux-pci@vger.kernel.org, xen-devel@lists.xensource.com
Subject: Re: Is msix_flush_writes() really needed? And multi_msi_*() flawed?
Date: Mon, 10 Nov 2008 10:07:50 +1100 [thread overview]
Message-ID: <1226272070.7205.4.camel@localhost> (raw)
In-Reply-To: <4914102D.76E4.0078.0@novell.com>
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
On Fri, 2008-11-07 at 08:53 +0000, Jan Beulich wrote:
> msix_flush_writes() is being called exclusively after calling msi_set_mask_bit(),
> and that function already does follow writel() by readl() in the MSI-X case.
Which makes me wonder why the initial patch was necessary?
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=988cbb15e00e6f924d052874b40c6a5447f9fdd7
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/pci/msi.c;h=a4ef93ea4c547b78bf80b5b12c9c20101bd3a1ec;hb=988cbb15e00e6f924d052874b40c6a5447f9fdd7
AFAICS there was already a readl() in msi_set_mask_bit(), so either the
initial patch didn't do anything useful or we're missing the point.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-09 23:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 8:53 Is msix_flush_writes() really needed? And multi_msi_*() flawed? Jan Beulich
2008-11-08 8:28 ` Grant Grundler
2008-11-08 14:10 ` Matthew Wilcox
2008-11-08 18:37 ` Grant Grundler
2008-11-09 2:13 ` Matthew Wilcox
2008-11-09 7:52 ` Grant Grundler
2008-11-10 8:38 ` Jan Beulich
2008-11-09 23:07 ` Michael Ellerman [this message]
2008-11-10 4:34 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226272070.7205.4.camel@localhost \
--to=michael@ellerman.id.au \
--cc=jbeulich@novell.com \
--cc=linux-pci@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.