* OOPS in OMAP 1-wire driver
@ 2008-11-20 0:40 Juha Kuikka
2008-11-20 3:27 ` stanley.miao
2008-11-21 0:06 ` Madhusudhan Chikkature
0 siblings, 2 replies; 3+ messages in thread
From: Juha Kuikka @ 2008-11-20 0:40 UTC (permalink / raw)
To: linux-omap@vger.kernel.org
I'm not sure this is the right place for 1-wire stuff but I remember
seeing patches for the OMAP 1w driver so maybe someone is interested.
Running git head on OMAP2430 SDP. Only OMAP master is built into the
kernel, no slave modules.
This happens on boot.
Driver for 1-wire Dallas network protocol.
omap_hdq omap_hdq.0: OMAP HDQ Hardware Rev 0.3. Driver in Interrupt mode
Unable to handle kernel NULL pointer dereference at virtual address 000000f0
pgd = c0004000
[000000f0] *pgd=00000000
Internal error: Oops: 0 [#1] PREEMPT
Modules linked in:
CPU: 0 Not tainted (2.6.28-rc5-omap1 #21)
PC is at 0xf0
LR is at omap_w1_search_bus+0x64/0x70
pc : [<000000f0>] lr : [<c01af368>] psr: 60000013
sp : c7957f68 ip : c7957f68 fp : c7957f8c
r10: 00000000 r9 : 00000000 r8 : 00000000
r7 : 000000f0 r6 : c7829160 r5 : 00000000 r4 : 00000001
r3 : 3d000000 r2 : 00000001 r1 : 3d000000 r0 : c7829160
Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
Control: 00c5387f Table: 80004000 DAC: 00000017
Process w1_bus_master1 (pid: 263, stack limit = 0xc7956260)
Stack: (0xc7957f68 to 0xc7958000)
7f60: 00000001 00000000 c01af304 000000f0 c7956000 000003e8
7f80: c7957fa4 c7957f90 c01aed58 c01af310 c7943a00 c7943a00 c7957fbc c7957fa8
7fa0: c01ad880 c01aed20 c7943a68 c7943a00 c7957fdc c7957fc0 c01ad958 c01ad830
7fc0: c7943a00 c01ad8fc 00000000 00000000 c7957ff4 c7957fe0 c0059fd0 c01ad908
7fe0: 00000000 00000000 00000000 c7957ff8 c0048104 c0059f88 ff00ff00 ff00ff00
Backtrace:
[<c01af304>] (omap_w1_search_bus+0x0/0x70) from [<c01aed58>]
(w1_search_devices+0x44/0x50)
r7:000003e8 r6:c7956000 r5:000000f0 r4:c01af304
[<c01aed14>] (w1_search_devices+0x0/0x50) from [<c01ad880>]
(w1_search_process+0x5c/0xd8)
r5:c7943a00 r4:c7943a00
[<c01ad824>] (w1_search_process+0x0/0xd8) from [<c01ad958>]
(w1_process+0x5c/0xe0)
r5:c7943a00 r4:c7943a68
[<c01ad8fc>] (w1_process+0x0/0xe0) from [<c0059fd0>] (kthread+0x54/0x80)
r7:00000000 r6:00000000 r5:c01ad8fc r4:c7943a00
[<c0059f7c>] (kthread+0x0/0x80) from [<c0048104>] (do_exit+0x0/0x784)
r5:00000000 r4:00000000
Code: bad PC value.
--
Madness takes it's toll. Please have exact change.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: OOPS in OMAP 1-wire driver
2008-11-20 0:40 OOPS in OMAP 1-wire driver Juha Kuikka
@ 2008-11-20 3:27 ` stanley.miao
2008-11-21 0:06 ` Madhusudhan Chikkature
1 sibling, 0 replies; 3+ messages in thread
From: stanley.miao @ 2008-11-20 3:27 UTC (permalink / raw)
To: Juha Kuikka; +Cc: linux-omap@vger.kernel.org
It has been fixed and the patch was added to -mm tree.
Stanley.
From: "Stanley.Miao" <stanley.miao@windriver.com>
OMAP LDP boot crash. This is because w1 subsystem changed the search
interface, so update omap_hdq's search interface to follow the change.
Signed-off-by: Stanley.Miao <stanley.miao@windriver.com>
Signed-off-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/w1/masters/omap_hdq.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff -puN drivers/w1/masters/omap_hdq.c~w1-omap-fix-omap-ldp-boot-crash
drivers/w1/masters/omap_hdq.c
--- a/drivers/w1/masters/omap_hdq.c~w1-omap-fix-omap-ldp-boot-crash
+++ a/drivers/w1/masters/omap_hdq.c
@@ -86,8 +86,8 @@ static struct platform_driver omap_hdq_d
static u8 omap_w1_read_byte(void *_hdq);
static void omap_w1_write_byte(void *_hdq, u8 byte);
static u8 omap_w1_reset_bus(void *_hdq);
-static void omap_w1_search_bus(void *_hdq, u8 search_type,
- w1_slave_found_callback slave_found);
+static void omap_w1_search_bus(void *_hdq, struct w1_master
*master_dev,
+ u8 search_type, w1_slave_found_callback slave_found);
static struct w1_bus_master omap_w1_master = {
@@ -231,8 +231,8 @@ static u8 omap_w1_reset_bus(void *_hdq)
}
/* W1 search callback function */
-static void omap_w1_search_bus(void *_hdq, u8 search_type,
- w1_slave_found_callback slave_found)
+static void omap_w1_search_bus(void *_hdq, struct w1_master
*master_dev,
+ u8 search_type, w1_slave_found_callback slave_found)
{
u64 module_id, rn_le, cs, id;
@@ -249,7 +249,7 @@ static void omap_w1_search_bus(void *_hd
cs = w1_calc_crc8((u8 *)&rn_le, 7);
id = (cs << 56) | module_id;
- slave_found(_hdq, id);
+ slave_found(master_dev, id);
}
static int _omap_hdq_reset(struct hdq_data *hdq_data)
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: OOPS in OMAP 1-wire driver
2008-11-20 0:40 OOPS in OMAP 1-wire driver Juha Kuikka
2008-11-20 3:27 ` stanley.miao
@ 2008-11-21 0:06 ` Madhusudhan Chikkature
1 sibling, 0 replies; 3+ messages in thread
From: Madhusudhan Chikkature @ 2008-11-21 0:06 UTC (permalink / raw)
To: Juha Kuikka; +Cc: linux-omap@vger.kernel.org
Hi,
I have not seen this crash before. If no slave modules are selected I see a
message that tells with a family ID not registered. But not a crash.
Regards,
Madhu
> I'm not sure this is the right place for 1-wire stuff but I remember
> seeing patches for the OMAP 1w driver so maybe someone is interested.
>
> Running git head on OMAP2430 SDP. Only OMAP master is built into the
> kernel, no slave modules.
> This happens on boot.
>
> Driver for 1-wire Dallas network protocol.
> omap_hdq omap_hdq.0: OMAP HDQ Hardware Rev 0.3. Driver in Interrupt mode
> Unable to handle kernel NULL pointer dereference at virtual address 000000f0
> pgd = c0004000
> [000000f0] *pgd=00000000
> Internal error: Oops: 0 [#1] PREEMPT
> Modules linked in:
> CPU: 0 Not tainted (2.6.28-rc5-omap1 #21)
> PC is at 0xf0
> LR is at omap_w1_search_bus+0x64/0x70
> pc : [<000000f0>] lr : [<c01af368>] psr: 60000013
> sp : c7957f68 ip : c7957f68 fp : c7957f8c
> r10: 00000000 r9 : 00000000 r8 : 00000000
> r7 : 000000f0 r6 : c7829160 r5 : 00000000 r4 : 00000001
> r3 : 3d000000 r2 : 00000001 r1 : 3d000000 r0 : c7829160
> Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
> Control: 00c5387f Table: 80004000 DAC: 00000017
> Process w1_bus_master1 (pid: 263, stack limit = 0xc7956260)
> Stack: (0xc7957f68 to 0xc7958000)
> 7f60: 00000001 00000000 c01af304 000000f0 c7956000 000003e8
> 7f80: c7957fa4 c7957f90 c01aed58 c01af310 c7943a00 c7943a00 c7957fbc c7957fa8
> 7fa0: c01ad880 c01aed20 c7943a68 c7943a00 c7957fdc c7957fc0 c01ad958 c01ad830
> 7fc0: c7943a00 c01ad8fc 00000000 00000000 c7957ff4 c7957fe0 c0059fd0 c01ad908
> 7fe0: 00000000 00000000 00000000 c7957ff8 c0048104 c0059f88 ff00ff00 ff00ff00
> Backtrace:
> [<c01af304>] (omap_w1_search_bus+0x0/0x70) from [<c01aed58>]
> (w1_search_devices+0x44/0x50)
> r7:000003e8 r6:c7956000 r5:000000f0 r4:c01af304
> [<c01aed14>] (w1_search_devices+0x0/0x50) from [<c01ad880>]
> (w1_search_process+0x5c/0xd8)
> r5:c7943a00 r4:c7943a00
> [<c01ad824>] (w1_search_process+0x0/0xd8) from [<c01ad958>]
> (w1_process+0x5c/0xe0)
> r5:c7943a00 r4:c7943a68
> [<c01ad8fc>] (w1_process+0x0/0xe0) from [<c0059fd0>] (kthread+0x54/0x80)
> r7:00000000 r6:00000000 r5:c01ad8fc r4:c7943a00
> [<c0059f7c>] (kthread+0x0/0x80) from [<c0048104>] (do_exit+0x0/0x784)
> r5:00000000 r4:00000000
> Code: bad PC value.
>
>
> --
> Madness takes it's toll. Please have exact change.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-21 0:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-20 0:40 OOPS in OMAP 1-wire driver Juha Kuikka
2008-11-20 3:27 ` stanley.miao
2008-11-21 0:06 ` Madhusudhan Chikkature
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.