All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Hannes Eder <hannes@hanneseder.net>
Cc: David Howells <dhowells@redhat.com>,
	James Morris <jmorris@namei.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] CRED: fix sparse warnings
Date: Tue, 25 Nov 2008 00:56:58 +0000	[thread overview]
Message-ID: <1227574619.5511.33.camel@brick> (raw)
In-Reply-To: <154e089b0811241646y6ada2c97l5e45284969729e29@mail.gmail.com>

On Tue, 2008-11-25 at 01:46 +0100, Hannes Eder wrote:
> On Tue, Nov 25, 2008 at 12:21 AM, David Howells <dhowells@redhat.com> wrote:
> > Hannes Eder <hannes@hanneseder.net> wrote:
> >
> >>   security/security.c:228:2: warning: returning void-valued expression
> >>   security/security.c:233:2: warning: returning void-valued expression
> >>   security/security.c:616:2: warning: returning void-valued expression
> >
> > What's wrong with that?

Well, there's still a few left, I kind of stopped going after this
class of sparse warnings.

But if you're up to it:
mm/hugetlb.c:375:3: warning: returning void-valued expression
mm/hugetlb.c:408:3: warning: returning void-valued expression
fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression
security/security.c:228:2: warning: returning void-valued expression
security/security.c:233:2: warning: returning void-valued expression
security/security.c:616:2: warning: returning void-valued expression
drivers/ide/alim15x3.c:594:2: warning: returning void-valued expression
drivers/isdn/i4l/isdn_net.c:1981:3: warning: returning void-valued expression
drivers/rtc/rtc-ds1511.c:634:2: warning: returning void-valued expression
drivers/rtc/rtc-stk17ta8.c:403:2: warning: returning void-valued expression
drivers/video/nvidia/nv_accel.c:304:3: warning: returning void-valued expression
drivers/video/nvidia/nv_accel.c:323:3: warning: returning void-valued expression
drivers/video/via/viafbdev.c:871:3: warning: returning void-valued expression
drivers/video/via/viafbdev.c:938:3: warning: returning void-valued expression
drivers/video/via/viafbdev.c:995:3: warning: returning void-valued expression
drivers/video/pm3fb.c:543:3: warning: returning void-valued expression
drivers/video/neofb.c:1456:4: warning: returning void-valued expression
drivers/video/neofb.c:1464:3: warning: returning void-valued expression
drivers/video/i810/i810_accel.c:305:3: warning: returning void-valued expression
drivers/video/i810/i810_accel.c:331:3: warning: returning void-valued expression
drivers/video/i810/i810_accel.c:370:3: warning: returning void-valued expression
drivers/video/intelfb/intelfbdrv.c:1497:3: warning: returning void-valued expression
drivers/video/intelfb/intelfbdrv.c:1525:3: warning: returning void-valued expression
drivers/video/intelfb/intelfbdrv.c:1544:3: warning: returning void-valued expression
drivers/video/intelfb/intelfbdrv.c:1558:3: warning: returning void-valued expression
sound/sound_core.c:460:2: warning: returning void-valued expression
sound/sound_core.c:477:2: warning: returning void-valued expression

Cheers,

Harvey


WARNING: multiple messages have this Message-ID (diff)
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Hannes Eder <hannes@hanneseder.net>
Cc: David Howells <dhowells@redhat.com>,
	James Morris <jmorris@namei.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] CRED: fix sparse warnings
Date: Mon, 24 Nov 2008 16:56:58 -0800	[thread overview]
Message-ID: <1227574619.5511.33.camel@brick> (raw)
In-Reply-To: <154e089b0811241646y6ada2c97l5e45284969729e29@mail.gmail.com>

On Tue, 2008-11-25 at 01:46 +0100, Hannes Eder wrote:
> On Tue, Nov 25, 2008 at 12:21 AM, David Howells <dhowells@redhat.com> wrote:
> > Hannes Eder <hannes@hanneseder.net> wrote:
> >
> >>   security/security.c:228:2: warning: returning void-valued expression
> >>   security/security.c:233:2: warning: returning void-valued expression
> >>   security/security.c:616:2: warning: returning void-valued expression
> >
> > What's wrong with that?

Well, there's still a few left, I kind of stopped going after this
class of sparse warnings.

But if you're up to it:
mm/hugetlb.c:375:3: warning: returning void-valued expression
mm/hugetlb.c:408:3: warning: returning void-valued expression
fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression
security/security.c:228:2: warning: returning void-valued expression
security/security.c:233:2: warning: returning void-valued expression
security/security.c:616:2: warning: returning void-valued expression
drivers/ide/alim15x3.c:594:2: warning: returning void-valued expression
drivers/isdn/i4l/isdn_net.c:1981:3: warning: returning void-valued expression
drivers/rtc/rtc-ds1511.c:634:2: warning: returning void-valued expression
drivers/rtc/rtc-stk17ta8.c:403:2: warning: returning void-valued expression
drivers/video/nvidia/nv_accel.c:304:3: warning: returning void-valued expression
drivers/video/nvidia/nv_accel.c:323:3: warning: returning void-valued expression
drivers/video/via/viafbdev.c:871:3: warning: returning void-valued expression
drivers/video/via/viafbdev.c:938:3: warning: returning void-valued expression
drivers/video/via/viafbdev.c:995:3: warning: returning void-valued expression
drivers/video/pm3fb.c:543:3: warning: returning void-valued expression
drivers/video/neofb.c:1456:4: warning: returning void-valued expression
drivers/video/neofb.c:1464:3: warning: returning void-valued expression
drivers/video/i810/i810_accel.c:305:3: warning: returning void-valued expression
drivers/video/i810/i810_accel.c:331:3: warning: returning void-valued expression
drivers/video/i810/i810_accel.c:370:3: warning: returning void-valued expression
drivers/video/intelfb/intelfbdrv.c:1497:3: warning: returning void-valued expression
drivers/video/intelfb/intelfbdrv.c:1525:3: warning: returning void-valued expression
drivers/video/intelfb/intelfbdrv.c:1544:3: warning: returning void-valued expression
drivers/video/intelfb/intelfbdrv.c:1558:3: warning: returning void-valued expression
sound/sound_core.c:460:2: warning: returning void-valued expression
sound/sound_core.c:477:2: warning: returning void-valued expression

Cheers,

Harvey


  reply	other threads:[~2008-11-25  0:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 21:14 [PATCH] CRED: fix sparse warnings Hannes Eder
2008-11-24 21:14 ` Hannes Eder
2008-11-24 23:21 ` David Howells
2008-11-25  0:46   ` Hannes Eder
2008-11-25  0:46     ` Hannes Eder
2008-11-25  0:56     ` Harvey Harrison [this message]
2008-11-25  0:56       ` Harvey Harrison
2008-11-25  6:39       ` Julia Lawall
2008-11-25  6:39         ` Julia Lawall
2008-11-25  1:08 ` James Morris
2008-11-25  1:08   ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227574619.5511.33.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=hannes@hanneseder.net \
    --cc=jmorris@namei.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.