[PATCH] ASoC: Fix TW4030 Kconfig dependency

[PATCH] ASoC: Fix TW4030 Kconfig dependency

[arunks]

From: Arun KS <arunks@mistralsolutions.com>

Fixes Kconfig dependency of TWL4030 audio codec driver
with TWL4030 core driver on both overo and omap2evm
boards

Signed-off-by: Arun KS <arunks@mistralsolutions.com>
---
 sound/soc/omap/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
index 6c56277..0900437 100644
--- a/sound/soc/omap/Kconfig
+++ b/sound/soc/omap/Kconfig
@@ -24,7 +24,7 @@ config SND_OMAP_SOC_OSK5912
 
 config SND_OMAP_SOC_OVERO
 	tristate "SoC Audio support for Gumstix Overo"
-	depends on SND_OMAP_SOC && MACH_OVERO
+	depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OVERO
 	select SND_OMAP_SOC_MCBSP
 	select SND_SOC_TWL4030
 	help
@@ -32,7 +32,7 @@ config SND_OMAP_SOC_OVERO
 
 config SND_OMAP_SOC_OMAP2EVM
 	tristate "SoC Audio support for OMAP2EVM board"
-	depends on SND_OMAP_SOC && MACH_OMAP2EVM
+	depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP2EVM
 	select SND_OMAP_SOC_MCBSP
 	select SND_SOC_TWL4030
 	help
-- 
1.5.6.3

Re: [PATCH] ASoC: Fix TW4030 Kconfig dependency

[David Brownell]

On Monday 24 November 2008, arunks@mistralsolutions.com wrote:
> From: Arun KS <arunks@mistralsolutions.com>
> 
> Fixes Kconfig dependency of TWL4030 audio codec driver
> with TWL4030 core driver on both overo and omap2evm
> boards
> 
> Signed-off-by: Arun KS <arunks@mistralsolutions.com>

Good idea.  :)

Acked-by: David Brownell <dbrownell@users.sourceforge.net>


> ---
>  sound/soc/omap/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
> index 6c56277..0900437 100644
> --- a/sound/soc/omap/Kconfig
> +++ b/sound/soc/omap/Kconfig
> @@ -24,7 +24,7 @@ config SND_OMAP_SOC_OSK5912
>  
>  config SND_OMAP_SOC_OVERO
>  	tristate "SoC Audio support for Gumstix Overo"
> -	depends on SND_OMAP_SOC && MACH_OVERO
> +	depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OVERO
>  	select SND_OMAP_SOC_MCBSP
>  	select SND_SOC_TWL4030
>  	help
> @@ -32,7 +32,7 @@ config SND_OMAP_SOC_OVERO
>  
>  config SND_OMAP_SOC_OMAP2EVM
>  	tristate "SoC Audio support for OMAP2EVM board"
> -	depends on SND_OMAP_SOC && MACH_OMAP2EVM
> +	depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP2EVM
>  	select SND_OMAP_SOC_MCBSP
>  	select SND_SOC_TWL4030
>  	help
> -- 
> 1.5.6.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Re: [PATCH] ASoC: Fix TW4030 Kconfig dependency

[Mark Brown]

On Mon, Nov 24, 2008 at 08:44:13PM -0800, David Brownell wrote:
> On Monday 24 November 2008, arunks@mistralsolutions.com wrote:

> > Fixes Kconfig dependency of TWL4030 audio codec driver
> > with TWL4030 core driver on both overo and omap2evm
> > boards

> > Signed-off-by: Arun KS <arunks@mistralsolutions.com>

> Good idea.  :)

> Acked-by: David Brownell <dbrownell@users.sourceforge.net>

Applied.

Might it be an idea to have the relevant machine drivers select the
TWL4030 support?  This would prevent them disabling it but the chip is
such a basic part of these systems that that doesn't seem unreasonable.

Re: [alsa-devel] [PATCH] ASoC: Fix TW4030 Kconfig dependency

[David Brownell]

On Tuesday 25 November 2008, Mark Brown wrote:
> Might it be an idea to have the relevant machine drivers select the
> TWL4030 support?  This would prevent them disabling it but the chip is
> such a basic part of these systems that that doesn't seem unreasonable.

I'm not sure what you mean by "machine driver" ... there seem
to be two:  arch/arm/mach-omap2/board-*.c for everything except
ALSA, and then sound/soc/omap/*.c for the ASoC bits.

As a rule, it's worth avoiding "select" in Kconfig; it doesn't
work well, since it won't even report missing dependencies much
less fix the trivial ones.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH] ASoC: Fix TW4030 Kconfig dependency

[Mark Brown]

On Tue, Nov 25, 2008 at 10:54:28AM -0800, David Brownell wrote:

> I'm not sure what you mean by "machine driver" ... there seem
> to be two:  arch/arm/mach-omap2/board-*.c for everything except
> ALSA, and then sound/soc/omap/*.c for the ASoC bits.

I meant the arch/arm one.

> As a rule, it's worth avoiding "select" in Kconfig; it doesn't
> work well, since it won't even report missing dependencies much
> less fix the trivial ones.

Right, I'm just thinking that for something like this it might not be
worth turning off the TWL4030 core support given that these sorts of
southbridgeish chips tend to be pretty key to the system.  It was just
an idle thought, anyway.

BTW, it'd also be really handy if you could remove the OMAP dependencies
from TWL4030_CORE - I know it currently needs them to actually be useful
at runtime but it'd mean that it's possible to build things like the
codec driver on other configs which helps when working on subsystems.

Re: [alsa-devel] [PATCH] ASoC: Fix TW4030 Kconfig dependency

[David Brownell]

On Tuesday 25 November 2008, Mark Brown wrote:
> BTW, it'd also be really handy if you could remove the OMAP dependencies
> from TWL4030_CORE - I know it currently needs them to actually be useful
> at runtime but it'd mean that it's possible to build things like the
> codec driver on other configs which helps when working on subsystems.

Patches for that are ready, but need a bit more testing
in the OMAP tree before they go to mainline.  I may prep
the mainline patches anyway ... the patches are roughly

 - updates to twl4030-core device creation, which
   are now in the OMAP tree, passing more IRQs via
   platform_device resources;

 - updates to various TWL drivers that won't go to
   mainline for a while, so they get the IRQs from
   those new resources;

 - removing the global IRQ symbols from the headers,
   and thus the OMAP dependencies.

The need for testing is from that second set of
patches.  There's also regulator framework stuff.

- Dave