RE: [PATCH] kvm: ppc: stop leaking host memory on VM exit

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Hollis Blanchard <hollisb@us.ibm.com>
To: Liu Yu <Yu.Liu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	kvm <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH] kvm: ppc: stop leaking host memory on VM exit
Date: Tue, 25 Nov 2008 16:52:11 +0000	[thread overview]
Message-ID: <1227631931.7434.9.camel@localhost.localdomain> (raw)
In-Reply-To: <D8176E55B81822498D63816C4ADC701023423D-bKEhWGtIRUJ4Lp7cDGe+DVjVikpgYyvb5NbjCUgZEJk@public.gmane.org>

On Tue, 2008-11-25 at 16:32 +0800, Liu Yu wrote:
> > -----Original Message-----
> > From: kvm-ppc-owner@vger.kernel.org 
> > [mailto:kvm-ppc-owner@vger.kernel.org] On Behalf Of Hollis Blanchard
> > Sent: Tuesday, November 25, 2008 1:38 AM
> > To: Avi Kivity
> > Cc: kvm-ppc; kvm
> > Subject: [PATCH] kvm: ppc: stop leaking host memory on VM exit
> > 
> > When the VM exits, we must call put_page() for every page 
> > referenced in the
> > shadow TLB.
> > 
> > Without this patch, we usually leak 30-50 host pages (120 - 
> > 200 KiB with 4 KiB
> > pages). The maximum number of pages leaked is the size of our 
> > shadow TLB, 64
> > pages.
> > 
> > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> 
> Need it also to _tlbia() at vcpu_uninit?

No, because by the time we hit kvm_arch_vcpu_uninit(),
kvm_arch_vcpu_put() has already been called.

-- 
Hollis Blanchard
IBM Linux Technology Center

WARNING: multiple messages have this Message-ID (diff)

From: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Liu Yu <Yu.Liu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	kvm <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH] kvm: ppc: stop leaking host memory on VM exit
Date: Tue, 25 Nov 2008 10:52:11 -0600	[thread overview]
Message-ID: <1227631931.7434.9.camel@localhost.localdomain> (raw)
In-Reply-To: <D8176E55B81822498D63816C4ADC701023423D-bKEhWGtIRUJ4Lp7cDGe+DVjVikpgYyvb5NbjCUgZEJk@public.gmane.org>

On Tue, 2008-11-25 at 16:32 +0800, Liu Yu wrote:
> > -----Original Message-----
> > From: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org 
> > [mailto:kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Hollis Blanchard
> > Sent: Tuesday, November 25, 2008 1:38 AM
> > To: Avi Kivity
> > Cc: kvm-ppc; kvm
> > Subject: [PATCH] kvm: ppc: stop leaking host memory on VM exit
> > 
> > When the VM exits, we must call put_page() for every page 
> > referenced in the
> > shadow TLB.
> > 
> > Without this patch, we usually leak 30-50 host pages (120 - 
> > 200 KiB with 4 KiB
> > pages). The maximum number of pages leaked is the size of our 
> > shadow TLB, 64
> > pages.
> > 
> > Signed-off-by: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> 
> Need it also to _tlbia() at vcpu_uninit?

No, because by the time we hit kvm_arch_vcpu_uninit(),
kvm_arch_vcpu_put() has already been called.

-- 
Hollis Blanchard
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

next prev parent reply	other threads:[~2008-11-25 16:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 17:37 [PATCH] kvm: ppc: stop leaking host memory on VM exit Hollis Blanchard
2008-11-24 17:37 ` Hollis Blanchard
     [not found] ` <1227548258.17746.11.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-11-25  2:28   ` Liu Yu
2008-11-25  2:28     ` Liu Yu
2008-11-25  8:32 ` Liu Yu
2008-11-25  8:32   ` Liu Yu
     [not found]   ` <D8176E55B81822498D63816C4ADC701023423D-bKEhWGtIRUJ4Lp7cDGe+DVjVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2008-11-25 16:52     ` Hollis Blanchard [this message]
2008-11-25 16:52       ` Hollis Blanchard
2008-11-25 11:00 ` Avi Kivity
2008-11-25 11:00   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227631931.7434.9.camel@localhost.localdomain \
    --to=hollisb@us.ibm.com \
    --cc=Yu.Liu-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.