From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org,
Shaddy Baddah <shaddy_baddah@hotmail.com>
Cc: Michael Buesch <mb@bu3sch.de>
Subject: Re: zd1211rw (2.6.26 sparc64): unaligned access (zd_mac_rx)
Date: Sat, 29 Nov 2008 10:50:04 +0100 [thread overview]
Message-ID: <1227952204.3542.3.camel@johannes.berg> (raw)
In-Reply-To: <49310454.60906@hotmail.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
On Sat, 2008-11-29 at 19:59 +1100, Shaddy Baddah wrote:
> net/mac80211/tx.c:1304: if (memcmp(odev->dev_addr, hdr->addr4,
> ETH_ALEN) != 0)
>
> I would have thought it would use compare_ether_addr() if we could
> safely assume alignment.
You're looking at the TX path, that's irrelevant :)
> In any case, say that alignment was always the
> intention... then can't we just use memcmp() as a hack (not being
> derogatory. Just that it would turn into a hack in deference to using
> compare_ether_addr()) consistent with hacks like the above? Even in the
> interim until a program to iron out alignment is set in place?
No, the IP stack assumes alignment. Besides, zd1211 actually enforces
the alignment before passing the skb off to mac80211.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-11-29 9:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 8:54 zd1211rw (2.6.26 sparc64): unaligned access (zd_mac_rx) Shaddy Baddah
2008-10-25 9:17 ` Johannes Berg
2008-10-25 11:25 ` Sebastian Andrzej Siewior
2008-10-25 12:05 ` Johannes Berg
2008-10-26 22:00 ` Sebastian Andrzej Siewior
2008-10-27 7:00 ` Johannes Berg
2008-10-25 11:21 ` Sebastian Andrzej Siewior
2008-10-25 11:25 ` Michael Buesch
2008-10-25 11:28 ` Sebastian Andrzej Siewior
2008-10-25 11:31 ` Michael Buesch
2008-10-25 11:38 ` Sebastian Andrzej Siewior
2008-10-25 15:13 ` Shaddy Baddah
2008-11-08 12:45 ` Shaddy Baddah
2008-11-08 12:45 ` Shaddy Baddah
2008-11-08 13:11 ` Johannes Berg
2008-11-09 3:06 ` Shaddy Baddah
2008-11-09 3:06 ` Shaddy Baddah
2008-11-09 3:08 ` Shaddy Baddah
2008-11-09 3:08 ` Shaddy Baddah
2008-11-09 12:00 ` Michael Buesch
2008-11-09 8:56 ` Johannes Berg
2008-11-09 9:03 ` Johannes Berg
2008-11-09 12:02 ` Michael Buesch
2008-11-09 18:31 ` Johannes Berg
2008-11-09 14:20 ` Shaddy Baddah
2008-11-09 14:20 ` Shaddy Baddah
2008-11-10 15:13 ` Shaddy Baddah
2008-11-10 15:13 ` Shaddy Baddah
2008-11-28 5:34 ` Shaddy Baddah
2008-11-28 5:34 ` Shaddy Baddah
2008-11-28 7:10 ` David Miller
2008-11-28 22:44 ` Michael Buesch
2008-11-29 8:59 ` Shaddy Baddah
2008-11-29 8:59 ` Shaddy Baddah
2008-11-29 9:50 ` Johannes Berg [this message]
2008-11-29 12:56 ` Shaddy Baddah
2008-11-29 12:56 ` Shaddy Baddah
2008-11-28 5:45 ` Shaddy Baddah
2008-11-28 5:45 ` Shaddy Baddah
2008-11-28 6:47 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227952204.3542.3.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=shaddy_baddah@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.