From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Shaddy Baddah <shaddy_baddah@hotmail.com>
Subject: Re: zd1211rw (2.6.26 sparc64): unaligned access (zd_mac_rx)
Date: Sun, 9 Nov 2008 13:02:15 +0100 [thread overview]
Message-ID: <200811091302.15899.mb@bu3sch.de> (raw)
In-Reply-To: <1226221438.3614.20.camel@johannes.berg>
On Sunday 09 November 2008 10:03:58 Johannes Berg wrote:
> On Sun, 2008-11-09 at 09:56 +0100, Johannes Berg wrote:
>
> > I think you forgot to attach the patch.
>
> Sorry, I missed your second mail. (btw, if you generate patches with -p
> in diff arguments it helps a bit reading them)
>
> Ok so it looks like the buffer you're getting is unaligned. This is
> strange, but I'm too unfamiliar with the code. It seems that there's the
> PLCP 5 byte header in front. Well, try the printk I asked for, because
> at that point zd1211 should avoid "leaking" the alignment problem.
zd1211rw has some code to align the packet to a 4-byte boundary.
But the compare_ether_addr() and the other le16 accesses are done before
that realignment.
This these blow up if (ieee80211_is_data_qos(fc) ^ ieee80211_has_a4(fc))
--
Greetings Michael.
next prev parent reply other threads:[~2008-11-09 12:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 8:54 zd1211rw (2.6.26 sparc64): unaligned access (zd_mac_rx) Shaddy Baddah
2008-10-25 9:17 ` Johannes Berg
2008-10-25 11:25 ` Sebastian Andrzej Siewior
2008-10-25 12:05 ` Johannes Berg
2008-10-26 22:00 ` Sebastian Andrzej Siewior
2008-10-27 7:00 ` Johannes Berg
2008-10-25 11:21 ` Sebastian Andrzej Siewior
2008-10-25 11:25 ` Michael Buesch
2008-10-25 11:28 ` Sebastian Andrzej Siewior
2008-10-25 11:31 ` Michael Buesch
2008-10-25 11:38 ` Sebastian Andrzej Siewior
2008-10-25 15:13 ` Shaddy Baddah
2008-11-08 12:45 ` Shaddy Baddah
2008-11-08 12:45 ` Shaddy Baddah
2008-11-08 13:11 ` Johannes Berg
2008-11-09 3:06 ` Shaddy Baddah
2008-11-09 3:06 ` Shaddy Baddah
2008-11-09 3:08 ` Shaddy Baddah
2008-11-09 3:08 ` Shaddy Baddah
2008-11-09 12:00 ` Michael Buesch
2008-11-09 8:56 ` Johannes Berg
2008-11-09 9:03 ` Johannes Berg
2008-11-09 12:02 ` Michael Buesch [this message]
2008-11-09 18:31 ` Johannes Berg
2008-11-09 14:20 ` Shaddy Baddah
2008-11-09 14:20 ` Shaddy Baddah
2008-11-10 15:13 ` Shaddy Baddah
2008-11-10 15:13 ` Shaddy Baddah
2008-11-28 5:34 ` Shaddy Baddah
2008-11-28 5:34 ` Shaddy Baddah
2008-11-28 7:10 ` David Miller
2008-11-28 22:44 ` Michael Buesch
2008-11-29 8:59 ` Shaddy Baddah
2008-11-29 8:59 ` Shaddy Baddah
2008-11-29 9:50 ` Johannes Berg
2008-11-29 12:56 ` Shaddy Baddah
2008-11-29 12:56 ` Shaddy Baddah
2008-11-28 5:45 ` Shaddy Baddah
2008-11-28 5:45 ` Shaddy Baddah
2008-11-28 6:47 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811091302.15899.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=shaddy_baddah@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.