All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: gerald.schaefer@de.ibm.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, schwidefsky@de.ibm.com,
	heiko.carstens@de.ibm.com, kamezawa.hiroyu@jp.fujitsu.com,
	y-goto@jp.fujitsu.com, npiggin@suse.de
Subject: Re: [PATCH] memory hotplug: run lru_add_drain_all() on each cpu
Date: Fri, 05 Dec 2008 12:43:38 -0800	[thread overview]
Message-ID: <1228509818.12681.21.camel@nimitz> (raw)
In-Reply-To: <1228482500.8392.15.camel@t60p>

On Fri, 2008-12-05 at 14:08 +0100, Gerald Schaefer wrote:
> 
> As explained above, the per-cpu pagevec layout should be independent
> from NUMA or UNEVICTABLE_LRU, so I guess the right thing to do here
> is completely remove the #ifdef as in the patch from Kosaki Motohiro
> (or at least replace it with a CONFIG_SMP as suggested by Kamezawa
> Hiroyuki).

Thanks for looking into it deeper.  That CONFIG_SMP thing really does
look like the right solution.

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: gerald.schaefer@de.ibm.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, schwidefsky@de.ibm.com,
	heiko.carstens@de.ibm.com, kamezawa.hiroyu@jp.fujitsu.com,
	y-goto@jp.fujitsu.com, npiggin@suse.de
Subject: Re: [PATCH] memory hotplug: run lru_add_drain_all() on each cpu
Date: Fri, 05 Dec 2008 12:43:38 -0800	[thread overview]
Message-ID: <1228509818.12681.21.camel@nimitz> (raw)
In-Reply-To: <1228482500.8392.15.camel@t60p>

On Fri, 2008-12-05 at 14:08 +0100, Gerald Schaefer wrote:
> 
> As explained above, the per-cpu pagevec layout should be independent
> from NUMA or UNEVICTABLE_LRU, so I guess the right thing to do here
> is completely remove the #ifdef as in the patch from Kosaki Motohiro
> (or at least replace it with a CONFIG_SMP as suggested by Kamezawa
> Hiroyuki).

Thanks for looking into it deeper.  That CONFIG_SMP thing really does
look like the right solution.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-12-05 20:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03 21:25 [PATCH] memory hotplug: run lru_add_drain_all() on each cpu Gerald Schaefer
2008-12-03 21:25 ` Gerald Schaefer
2008-12-03 22:16 ` Dave Hansen
2008-12-03 22:16   ` Dave Hansen
2008-12-04  0:31   ` KAMEZAWA Hiroyuki
2008-12-04  0:31     ` KAMEZAWA Hiroyuki
2008-12-04  2:14     ` [PATCH] mm: remove UP version lru_add_drain_all() KOSAKI Motohiro
2008-12-04  2:14       ` KOSAKI Motohiro
2008-12-04  2:23       ` KOSAKI Motohiro
2008-12-04  2:23         ` KOSAKI Motohiro
2008-12-04 18:01       ` Gerald Schaefer
2008-12-04 18:01         ` Gerald Schaefer
2008-12-05 13:08   ` [PATCH] memory hotplug: run lru_add_drain_all() on each cpu Gerald Schaefer
2008-12-05 13:08     ` Gerald Schaefer
2008-12-05 20:43     ` Dave Hansen [this message]
2008-12-05 20:43       ` Dave Hansen
2008-12-07  4:43       ` KOSAKI Motohiro
2008-12-07  4:43         ` KOSAKI Motohiro
2008-12-08 13:56         ` Lee Schermerhorn
2008-12-08 13:56           ` Lee Schermerhorn
2008-12-08 14:30           ` KOSAKI Motohiro
2008-12-08 14:30             ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1228509818.12681.21.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=gerald.schaefer@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=schwidefsky@de.ibm.com \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.