From: Peter Zijlstra <peterz@infradead.org>
To: Oliver Hartkopp <oliver@hartkopp.net>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC PATCH] hrtimer: removing all ur callback modes
Date: Tue, 09 Dec 2008 09:12:11 +0100 [thread overview]
Message-ID: <1228810331.12729.59.camel@twins> (raw)
In-Reply-To: <493E2725.7090305@hartkopp.net>
On Tue, 2008-12-09 at 09:07 +0100, Oliver Hartkopp wrote:
> I wouldn't be that sure that all the other sites can cope with it as i
> only detected the problems with my code under heavy load ...
Most other sites only fiddle some bits and do a wakeup of some task or
other - they usually already did spin_lock_irqsave() to protect the
state they poked at.
But sure, testing is always the best way.
> >> Any idea?
> >>
> >
> > What are the timing constraints of your problem? - I assume they are not
> > too aggressive, otherwise you'd not be able to run from softirq, could
> > you run from keventd?
> >
>
> I browsed some code that's using hrtimers and found some hopefully good
> example in drivers/s390/crypto/ap_bus.c : They are using the hrtimer to
> schedule a tasklet which is running in soft-irq context:
>
> http://lxr.linux.no/linux+v2.6.27.8/drivers/s390/crypto/ap_bus.c#L1150
>
> This could also be the correct approach for my sock_queue_rcv_skb()
> problem, right?
In as far as tasklets are correct, yes, that would work for you too.
> Regards,
> Oliver
>
> ps. What is the intended release for this hrtimer cleanup? 2.6.29?
I think so, Thomas, Ingo?
next prev parent reply other threads:[~2008-12-09 8:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 11:43 [RFC PATCH] hrtimer: removing all ur callback modes Peter Zijlstra
2008-11-25 14:46 ` Ingo Molnar
2008-11-25 15:03 ` Ingo Molnar
2008-12-04 10:17 ` Peter Zijlstra
2008-12-04 10:33 ` Ingo Molnar
2008-12-07 11:22 ` Oliver Hartkopp
2008-12-07 12:59 ` Oliver Hartkopp
2008-12-08 10:15 ` Peter Zijlstra
2008-12-08 11:00 ` Oliver Hartkopp
2008-12-08 15:25 ` Linus Torvalds
2008-12-09 13:32 ` Takashi Iwai
2008-12-09 8:07 ` Oliver Hartkopp
2008-12-09 8:12 ` Peter Zijlstra [this message]
2008-12-09 10:59 ` Ingo Molnar
2008-12-30 22:46 ` Oliver Hartkopp
2008-12-31 8:32 ` Oliver Hartkopp
2008-12-08 16:13 ` Peter Zijlstra
2008-12-08 16:15 ` Peter Zijlstra
2008-12-08 16:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228810331.12729.59.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oliver@hartkopp.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.