All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de,
	hmh@hmh.eng.br
Subject: Re: [RFC] b43: rework rfkill code
Date: Wed, 10 Dec 2008 17:51:38 +0100	[thread overview]
Message-ID: <1228927898.19553.164.camel@violet.holtmann.net> (raw)
In-Reply-To: <1228922997.15837.6.camel@johannes.berg>

Hi Johannes,

> > The final change is that I removed the code for changing the wireless 
> > state in response to the txpower configuration in mac80211. Right now, I 
> > can't see any way for this to work correctly - if the user disables the 
> > radio via rfkill, mac80211 doesn't flag the radio as disabled. As a 
> > result, the next time the configuration callback is called, b43 
> > reenables the radio again, even though the user has explicitly disabled 
> > it. I don't think any of the other drivers handle this case, so I'm not 
> > really sure what the best way to handle this in future is. The current 
> > situation certainly seems broken.
> 
> We're going to have to integrate rfkill with mac80211, but nobody cares.

if you figured out on how to do it the best way, then let me know,
because I have to do the same thing for Bluetooth.

Regards

Marcel



  parent reply	other threads:[~2008-12-10 16:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-10 15:09 [RFC] b43: rework rfkill code Matthew Garrett
2008-12-10 15:29 ` Johannes Berg
2008-12-10 16:15   ` Ivo van Doorn
2008-12-10 16:51   ` Marcel Holtmann [this message]
2008-12-10 17:18     ` Johannes Berg
2008-12-10 17:23       ` Johannes Berg
2008-12-10 17:28         ` Johannes Berg
2008-12-10 21:33           ` Henrique de Moraes Holschuh
2008-12-10 21:42             ` Michael Buesch
2008-12-10 17:31         ` Michael Buesch
2008-12-10 17:37           ` Johannes Berg
2008-12-10 17:51             ` Matthew Garrett
2008-12-10 18:04               ` Michael Buesch
2008-12-10 18:05               ` Johannes Berg
2008-12-10 18:09                 ` Matthew Garrett
2008-12-10 18:29                 ` Dan Williams
2008-12-10 18:33                   ` Johannes Berg
2008-12-10 18:59                     ` Dan Williams
2008-12-10 20:07                   ` Michael Buesch
2009-03-29 18:19     ` Johannes Berg
2008-12-11  0:32   ` Julian Calaby
2008-12-11  1:27     ` Michael Buesch
2008-12-11 13:28       ` Kalle Valo
2008-12-10 15:48 ` Michael Buesch
2008-12-10 16:12   ` Matthew Garrett
2008-12-11 16:55 ` Larry Finger
2008-12-12  4:28 ` Larry Finger
2008-12-17 15:48   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1228927898.19553.164.camel@violet.holtmann.net \
    --to=marcel@holtmann.org \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=hmh@hmh.eng.br \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.