All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: ca0106 MSI K8N Diamond MB spi_dac 2->1
@ 2008-12-16 14:26 Ben Stanley
  2008-12-16 14:51 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Stanley @ 2008-12-16 14:26 UTC (permalink / raw)
  To: alsa-devel

>From fe2e6692ea6fcdf93d724b8aa48e7433994e011c Mon Sep 17 00:00:00 2001
From: Ben Stanley <Ben.Stanley@exemail.com.au>
Date: Mon, 15 Dec 2008 23:38:12 +1100
Subject: [PATCH] ALSA: ca0106 MSI K8N Diamond MB spi_dac 2->1

This patch removes an inconsistency that became apparent when I 
documented the fields of snd_ca0106_details. spi_dac is always 
used in a 'boolean' sense, so this cleanup should make no difference.

Signed-off-by: Ben Stanley <Ben.Stanley@exemail.com.au>
---
 pci/ca0106/ca0106_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pci/ca0106/ca0106_main.c b/pci/ca0106/ca0106_main.c
index 88fbf28..6ac1936 100644
--- a/pci/ca0106/ca0106_main.c
+++ b/pci/ca0106/ca0106_main.c
@@ -254,7 +254,7 @@ static struct snd_ca0106_details ca0106_chip_details[] = {
 	   .name   = "MSI K8N Diamond MB",
 	   .gpio_type = 2,
 	   .i2c_adc = 1,
-	   .spi_dac = 2 } ,
+	   .spi_dac = 1 } ,
 	 /* Shuttle XPC SD31P which has an onboard Creative Labs
 	  * Sound Blaster Live! 24-bit EAX
 	  * high-definition 7.1 audio processor".
-- 
1.5.4.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: ca0106 MSI K8N Diamond MB spi_dac 2->1
  2008-12-16 14:26 [PATCH] ALSA: ca0106 MSI K8N Diamond MB spi_dac 2->1 Ben Stanley
@ 2008-12-16 14:51 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-12-16 14:51 UTC (permalink / raw)
  To: Ben Stanley; +Cc: alsa-devel

At Wed, 17 Dec 2008 01:26:27 +1100,
Ben Stanley wrote:
> 
> >From fe2e6692ea6fcdf93d724b8aa48e7433994e011c Mon Sep 17 00:00:00 2001
> From: Ben Stanley <Ben.Stanley@exemail.com.au>
> Date: Mon, 15 Dec 2008 23:38:12 +1100
> Subject: [PATCH] ALSA: ca0106 MSI K8N Diamond MB spi_dac 2->1
> 
> This patch removes an inconsistency that became apparent when I 
> documented the fields of snd_ca0106_details. spi_dac is always 
> used in a 'boolean' sense, so this cleanup should make no difference.
> 
> Signed-off-by: Ben Stanley <Ben.Stanley@exemail.com.au>

Applied with some additional comments as there is an explicit check
of spi_dac.

thanks,

Takashi

> ---
>  pci/ca0106/ca0106_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/pci/ca0106/ca0106_main.c b/pci/ca0106/ca0106_main.c
> index 88fbf28..6ac1936 100644
> --- a/pci/ca0106/ca0106_main.c
> +++ b/pci/ca0106/ca0106_main.c
> @@ -254,7 +254,7 @@ static struct snd_ca0106_details ca0106_chip_details[] = {
>  	   .name   = "MSI K8N Diamond MB",
>  	   .gpio_type = 2,
>  	   .i2c_adc = 1,
> -	   .spi_dac = 2 } ,
> +	   .spi_dac = 1 } ,
>  	 /* Shuttle XPC SD31P which has an onboard Creative Labs
>  	  * Sound Blaster Live! 24-bit EAX
>  	  * high-definition 7.1 audio processor".
> -- 
> 1.5.4.3
> 
> 
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-16 14:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-16 14:26 [PATCH] ALSA: ca0106 MSI K8N Diamond MB spi_dac 2->1 Ben Stanley
2008-12-16 14:51 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.