[PATCH 0/11] Add E500 support in KVM

[PATCH 0/11] Add E500 support in KVM

[Liu Yu]

This patch set add E500 support in KVM,
and is already based on Hollis's feedback (a patchset which not yet commit)

btw: The latest code seems broken with this error.
---
  CC      arch/powerpc/kvm/../../../virt/kvm/kvm_main.o
arch/powerpc/kvm/../../../virt/kvm/kvm_main.c: In function ‘make_all_cpus_request’:
arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:577: error: implicit declaration of function ‘smp_call_function_many’
make[1]: *** [arch/powerpc/kvm/../../../virt/kvm/kvm_main.o] Error 1
make: *** [arch/powerpc/kvm] Error 2
--

Fortunately, I could test these patch based on a commit a couple of days ago.

Re: [PATCH 0/11] Add E500 support in KVM

[Hollis Blanchard]

On Thu, 2008-12-11 at 17:11 +0800, Liu Yu wrote:
> This patch set add E500 support in KVM,
> and is already based on Hollis's feedback (a patchset which not yet commit)
> 
> btw: The latest code seems broken with this error.
> ---
>   CC      arch/powerpc/kvm/../../../virt/kvm/kvm_main.o
> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c: In function ‘make_all_cpus_request’:
> arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:577: error: implicit declaration of function ‘smp_call_function_many’
> make[1]: *** [arch/powerpc/kvm/../../../virt/kvm/kvm_main.o] Error 1
> make: *** [arch/powerpc/kvm] Error 2
> --

Looks like this problem was introduced Monday. I submitted a fix for it
a couple hours ago, but forgot to copy kvm-ppc (sorry). Hopefully it
will go in soon.

> Fortunately, I could test these patch based on a commit a couple of days ago.

Great.

-- 
Hollis Blanchard
IBM Linux Technology Center

Re: [PATCH 0/11] Add E500 support in KVM

[Hollis Blanchard]

On Thu, 2008-12-11 at 17:11 +0800, Liu Yu wrote:
> This patch set add E500 support in KVM,
> and is already based on Hollis's feedback (a patchset which not yet commit)

I'm fairly happy with this series, aside from the mostly minor comments
I've made so far. It's definitely a plus that you've managed not to
break 440 while writing this code, congratulations. :) If you're able to
revise them, I think we can commit these patches this week.

By the way, have you looked into reserving enough host memory to use
large pages for the guest kernel mapping? That will be critical to
getting good performance.

Also, do you have any qemu patches?

-- 
Hollis Blanchard
IBM Linux Technology Center

RE: [PATCH 0/11] Add E500 support in KVM

[Liu Yu]

> -----Original Message-----
> From: kvm-ppc-owner@vger.kernel.org 
> [mailto:kvm-ppc-owner@vger.kernel.org] On Behalf Of Hollis Blanchard
> Sent: Tuesday, December 16, 2008 9:42 AM
> To: Liu Yu-B13201
> Cc: kvm-ppc@vger.kernel.org
> Subject: Re: [PATCH 0/11] Add E500 support in KVM
> 
> On Thu, 2008-12-11 at 17:11 +0800, Liu Yu wrote:
> > This patch set add E500 support in KVM,
> > and is already based on Hollis's feedback (a patchset which 
> not yet commit)
> 
> I'm fairly happy with this series, aside from the mostly 
> minor comments I've made so far.
...

>  It's definitely a plus that you've managed not to
> break 440 while writing this code, congratulations. :) If 
> you're able to
> revise them, I think we can commit these patches this week.
> 
> By the way, have you looked into reserving enough host memory to use
> large pages for the guest kernel mapping? That will be critical to
> getting good performance.
Not yet.

> 
> Also, do you have any qemu patches?
> 
Still under process.

Re: [PATCH 0/11] Add E500 support in KVM

[Hollis Blanchard]

On Thu, 2008-12-11 at 17:11 +0800, Liu Yu wrote:
> This patch set add E500 support in KVM,
> and is already based on Hollis's feedback (a patchset which not yet commit)

For your convenience, I've published the latest supporting changes I
made at http://penguinppc.org/~hollisb/kvm/ . Some of these patches are
44x patches that you don't need, but they won't hurt anything to apply
them. Some of them are patches that have already been committed in other
trees, but haven't get arrived in kvm.git.

At any rate, you should be able to base your next set of patches on
that.

-- 
Hollis Blanchard
IBM Linux Technology Center