All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sheng Yang <sheng@linux.intel.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, Sheng Yang <sheng@linux.intel.com>
Subject: [PATCH 14/15] KVM: Replace host_irq_disable with a new flag
Date: Fri, 26 Dec 2008 10:29:13 +0800	[thread overview]
Message-ID: <1230258553-15159-1-git-send-email-sheng@linux.intel.com> (raw)
In-Reply-To: <1230196179-6918-15-git-send-email-sheng@linux.intel.com>

(I discard irq_fifo and change a method to fix this problem)

We can reused the field "state" later.

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 include/linux/kvm_host.h |    3 ++-
 virt/kvm/kvm_main.c      |    8 ++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index fbf102c..58e4b7e 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -311,13 +311,14 @@ struct kvm_assigned_dev_kernel {
 	int host_busnr;
 	int host_devfn;
 	int host_irq;
-	bool host_irq_disabled;
 	int guest_irq;
 #define KVM_ASSIGNED_DEV_GUEST_INTX	(1 << 0)
 #define KVM_ASSIGNED_DEV_GUEST_MSI	(1 << 1)
 #define KVM_ASSIGNED_DEV_HOST_INTX	(1 << 8)
 #define KVM_ASSIGNED_DEV_HOST_MSI	(1 << 9)
 	unsigned long irq_requested_type;
+#define KVM_ASSIGNED_DEV_HOST_IRQ_DISABLED	(1 << 0)
+	unsigned long state;
 	int irq_source_id;
 	struct pci_dev *dev;
 	struct kvm *kvm;
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index a51e630..065af2d 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -114,7 +114,7 @@ static void kvm_assigned_dev_interrupt_work_handler(struct work_struct *work)
 
 	if (assigned_dev->irq_requested_type & KVM_ASSIGNED_DEV_GUEST_MSI) {
 		enable_irq(assigned_dev->host_irq);
-		assigned_dev->host_irq_disabled = false;
+		assigned_dev->state &= ~KVM_ASSIGNED_DEV_HOST_IRQ_DISABLED;
 	}
 
 	mutex_unlock(&assigned_dev->kvm->lock);
@@ -131,7 +131,7 @@ static irqreturn_t kvm_assigned_dev_intr(int irq, void *dev_id)
 	schedule_work(&assigned_dev->interrupt_work);
 
 	disable_irq_nosync(irq);
-	assigned_dev->host_irq_disabled = true;
+	assigned_dev->state |= KVM_ASSIGNED_DEV_HOST_IRQ_DISABLED;
 
 	return IRQ_HANDLED;
 }
@@ -152,9 +152,9 @@ static void kvm_assigned_dev_ack_irq(struct kvm_irq_ack_notifier *kian)
 	/* The guest irq may be shared so this ack may be
 	 * from another device.
 	 */
-	if (dev->host_irq_disabled) {
+	if (dev->state & KVM_ASSIGNED_DEV_HOST_IRQ_DISABLED) {
 		enable_irq(dev->host_irq);
-		dev->host_irq_disabled = false;
+		dev->state &= ~KVM_ASSIGNED_DEV_HOST_IRQ_DISABLED;
 	}
 }
 
-- 
1.5.4.5


  reply	other threads:[~2008-12-26  2:29 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-25  9:09 [PATCH 0/15] Device assignment & MSI enhancement Sheng Yang
2008-12-25  9:09 ` [PATCH 01/15] KVM: Add MSI_ACTION flag for assigned irq Sheng Yang
2008-12-25  9:09 ` [PATCH 02/15] KVM: Use kvm_free_assigned_irq() for free irq Sheng Yang
2008-12-25  9:09 ` [PATCH 03/15] KVM: Add support to disable MSI for assigned device Sheng Yang
2008-12-25  9:09 ` [PATCH 04/15] KVM: Add a route layer to convert MSI message to GSI Sheng Yang
2008-12-25  9:09 ` [PATCH 05/15] KVM: Using gsi_msg mapping for MSI device assignment Sheng Yang
2008-12-25  9:09 ` [PATCH 06/15] KVM: Improve MSI dispatch function Sheng Yang
2008-12-25  9:09 ` [PATCH 07/15] KVM: Using ioapic_irqchip() macro for kvm_set_irq Sheng Yang
2008-12-25  9:09 ` [PATCH 08/15] KVM: Merge MSI handling to kvm_set_irq Sheng Yang
2008-12-25  9:09 ` [PATCH 09/15] KVM: Split IOAPIC structure Sheng Yang
2008-12-25  9:09 ` [PATCH 10/15] KVM: Unified the delivery of IOAPIC and MSI Sheng Yang
2008-12-25  9:09 ` [PATCH 11/15] KVM: Change API of kvm_ioapic_get_delivery_bitmask Sheng Yang
2008-12-25  9:09 ` [PATCH 12/15] KVM: Update intr delivery func to accept unsigned long* bitmap Sheng Yang
2008-12-25  9:09 ` [PATCH 13/15] KVM: bit ops for deliver_bitmap Sheng Yang
2008-12-25  9:09 ` [PATCH 14/15] KVM: Using kfifo for irq recording Sheng Yang
2008-12-26  2:29   ` Sheng Yang [this message]
2008-12-25  9:09 ` [PATCH 15/15] KVM: Fix racy in kvm_free_assigned_irq Sheng Yang
2008-12-25 11:56   ` Sheng Yang
2008-12-26  2:30     ` Sheng Yang
2008-12-27 20:06       ` Marcelo Tosatti
2008-12-27 20:15         ` Marcelo Tosatti
2008-12-28 11:24         ` Sheng Yang
2008-12-28 12:57           ` Avi Kivity
2008-12-29  5:42           ` Amit Shah
2008-12-29 12:23             ` Sheng Yang
2008-12-29 13:37               ` Avi Kivity
2008-12-29 13:49                 ` Sheng Yang
2008-12-29 15:20               ` Marcelo Tosatti
2008-12-30  2:14                 ` Sheng Yang
2008-12-30 16:45                   ` Marcelo Tosatti
2008-12-31  5:43                     ` Sheng Yang
2009-01-02  0:10                       ` Marcelo Tosatti
2009-01-05  7:07                         ` Sheng Yang
2009-01-05 13:27                           ` Avi Kivity
2009-01-06  1:25                             ` Sheng Yang
2008-12-29 13:20             ` Avi Kivity
2008-12-25  9:13 ` [PATCH 0/15] Device assignment & MSI enhancement Sheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1230258553-15159-1-git-send-email-sheng@linux.intel.com \
    --to=sheng@linux.intel.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.