From: Sheng Yang <sheng@linux.intel.com>
To: kvm@vger.kernel.org
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 0/15] Device assignment & MSI enhancement
Date: Thu, 25 Dec 2008 17:13:20 +0800 [thread overview]
Message-ID: <200812251713.21137.sheng@linux.intel.com> (raw)
In-Reply-To: <1230196179-6918-1-git-send-email-sheng@linux.intel.com>
On Thursday 25 December 2008 17:09:24 Sheng Yang wrote:
> Hi Avi and Marcelo
>
> Merry Xmas! And here is the v2 of patchset. Target at 2.6.29 for it
> contained a lot of fix and improvement of current device assignment and MSI
> feature.
>
> Change from V1:
>
> Addressed Marcelo's comments, and:
> 1. Fix racy in kvm_free_assigned_irq(). In case to do this, I fetch one
> patch (irq_fifo) from original MSI-X patchset. Indeed a nice catch of
> Marcelo.
>
> :)
>
> 2. Unified kvm_set_irq() with ioapic_deliver(). It didn't save much, but
> duplicate is always bothering, and I have modified bitmask for vcpu to a
> real bitmap (maybe not all, just what I have seen).
Forgot to mention, I didn't change API for guest to disable MSI which is a
part of Marcelo's comments, for I think single interface named "update" with
some flags represent the current bit state is enough for now...
--
regards
Yang, Sheng
>
> And for V1:
>
> 1. Add gsi_msg mapping mechanism, which gsi can used to indicated a MSI
> interrupt.(Notice API/ABI changed a little, but we don't have userspace
> patch now, so it should be OK.)
>
> 2. Provide MSI disable capability.
>
> arch/x86/kvm/lapic.c | 11 ++-
> include/linux/kvm.h | 15 +++-
> include/linux/kvm_host.h | 26 +++++-
> include/linux/kvm_types.h | 17 ++++
> virt/kvm/ioapic.c | 117 ++++++++++---------------
> virt/kvm/ioapic.h | 23 +----
> virt/kvm/irq_comm.c | 184 ++++++++++++++++++++++++++++++++++++---
> virt/kvm/kvm_main.c | 212
> ++++++++++++++++++++++++++++----------------- 8 files changed, 415
> insertions(+), 190 deletions(-)
>
> Sorry for the patchset size, it's too easy to grow fast, and I am a little
> too lazy to split them into more batches in the Xmas... :)
>
> --
> regards
> Yang, Sheng
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-12-25 9:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-25 9:09 [PATCH 0/15] Device assignment & MSI enhancement Sheng Yang
2008-12-25 9:09 ` [PATCH 01/15] KVM: Add MSI_ACTION flag for assigned irq Sheng Yang
2008-12-25 9:09 ` [PATCH 02/15] KVM: Use kvm_free_assigned_irq() for free irq Sheng Yang
2008-12-25 9:09 ` [PATCH 03/15] KVM: Add support to disable MSI for assigned device Sheng Yang
2008-12-25 9:09 ` [PATCH 04/15] KVM: Add a route layer to convert MSI message to GSI Sheng Yang
2008-12-25 9:09 ` [PATCH 05/15] KVM: Using gsi_msg mapping for MSI device assignment Sheng Yang
2008-12-25 9:09 ` [PATCH 06/15] KVM: Improve MSI dispatch function Sheng Yang
2008-12-25 9:09 ` [PATCH 07/15] KVM: Using ioapic_irqchip() macro for kvm_set_irq Sheng Yang
2008-12-25 9:09 ` [PATCH 08/15] KVM: Merge MSI handling to kvm_set_irq Sheng Yang
2008-12-25 9:09 ` [PATCH 09/15] KVM: Split IOAPIC structure Sheng Yang
2008-12-25 9:09 ` [PATCH 10/15] KVM: Unified the delivery of IOAPIC and MSI Sheng Yang
2008-12-25 9:09 ` [PATCH 11/15] KVM: Change API of kvm_ioapic_get_delivery_bitmask Sheng Yang
2008-12-25 9:09 ` [PATCH 12/15] KVM: Update intr delivery func to accept unsigned long* bitmap Sheng Yang
2008-12-25 9:09 ` [PATCH 13/15] KVM: bit ops for deliver_bitmap Sheng Yang
2008-12-25 9:09 ` [PATCH 14/15] KVM: Using kfifo for irq recording Sheng Yang
2008-12-26 2:29 ` [PATCH 14/15] KVM: Replace host_irq_disable with a new flag Sheng Yang
2008-12-25 9:09 ` [PATCH 15/15] KVM: Fix racy in kvm_free_assigned_irq Sheng Yang
2008-12-25 11:56 ` Sheng Yang
2008-12-26 2:30 ` Sheng Yang
2008-12-27 20:06 ` Marcelo Tosatti
2008-12-27 20:15 ` Marcelo Tosatti
2008-12-28 11:24 ` Sheng Yang
2008-12-28 12:57 ` Avi Kivity
2008-12-29 5:42 ` Amit Shah
2008-12-29 12:23 ` Sheng Yang
2008-12-29 13:37 ` Avi Kivity
2008-12-29 13:49 ` Sheng Yang
2008-12-29 15:20 ` Marcelo Tosatti
2008-12-30 2:14 ` Sheng Yang
2008-12-30 16:45 ` Marcelo Tosatti
2008-12-31 5:43 ` Sheng Yang
2009-01-02 0:10 ` Marcelo Tosatti
2009-01-05 7:07 ` Sheng Yang
2009-01-05 13:27 ` Avi Kivity
2009-01-06 1:25 ` Sheng Yang
2008-12-29 13:20 ` Avi Kivity
2008-12-25 9:13 ` Sheng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812251713.21137.sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.