From: Chris Mason <chris.mason@oracle.com>
To: Yan Zheng <yanzheng@21cn.com>
Cc: devzero@web.de, linux-btrfs@vger.kernel.org
Subject: Re: btrfs filesystem freeze
Date: Mon, 05 Jan 2009 16:24:55 -0500 [thread overview]
Message-ID: <1231190695.4290.148.camel@think.oraclecorp.com> (raw)
In-Reply-To: <3d0408630901051314i12ead163ye6936424a40047b5@mail.gmail.com>
On Tue, 2009-01-06 at 05:14 +0800, Yan Zheng wrote:
> 2009/1/5 Chris Mason <chris.mason@oracle.com>:
> > Which call to iput is causing problems? We're going to run into
> > starvation problems if file deletes use join.
> >
>
> btrfs_commit_transaction->create_pending_snapshots->
> create_pending_snapshot->btrfs_lookup_dentry->
> fixup_tree_root_location->btrfs_read_fs_root->
> btrfs_read_fs_root_no_name->btrfs_orphan_cleanup->iput
Ugh. we need to move the orphan cleanup out of the read_fs_root calls.
Could you please move it to the cleaner_kthread? Just run through the
dirty roots and call the orphan cleanup on each.
-chris
next prev parent reply other threads:[~2009-01-05 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 14:09 btrfs filesystem freeze devzero
2008-12-22 0:55 ` Yan Zheng
2009-01-05 15:44 ` Chris Mason
2009-01-05 21:14 ` Yan Zheng
2009-01-05 21:24 ` Chris Mason [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-23 0:26 devzero
2008-12-20 23:26 devzero
2008-12-21 11:13 ` Yan Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231190695.4290.148.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=devzero@web.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.