From: Yan Zheng <zheng.yan@oracle.com>
To: devzero@web.de
Cc: linux-btrfs@vger.kernel.org
Subject: Re: btrfs filesystem freeze
Date: Mon, 22 Dec 2008 08:55:33 +0800 [thread overview]
Message-ID: <494EE585.5090209@oracle.com> (raw)
In-Reply-To: <551034715@web.de>
devzero@web.de wrote:
> thank you.
>
> i tried your patch and did another test run.
>
> first, it looked better as i could do much more snapshots than before, but then it froze again.
>
> i don`t really have a clue if your patch enhanced anything, as my test setup isn`t exactly reproducable for now and i did not check for exact "testing lab conditions".
>
> after /btrfs froze again, i tried to unmount by forcibly unloading btrfs module.
>
> after reloading the module and trying to mount again, it failed with the following kernel message:
>
I hope the new patch can solve the problem.
Yan Zheng
---
diff -urp 1/fs/btrfs/inode.c 2/fs/btrfs/inode.c
--- 1/fs/btrfs/inode.c 2008-12-18 08:09:16.062111805 +0800
+++ 2/fs/btrfs/inode.c 2008-12-22 08:47:06.000000000 +0800
@@ -2891,7 +2891,7 @@ void btrfs_delete_inode(struct inode *in
btrfs_wait_ordered_range(inode, 0, (u64)-1);
btrfs_i_size_write(inode, 0);
- trans = btrfs_start_transaction(root, 1);
+ trans = btrfs_join_transaction(root, 1);
btrfs_set_trans_block_group(trans, inode);
ret = btrfs_truncate_inode_items(trans, root, inode, inode->i_size, 0);
diff -urp 1/fs/btrfs/transaction.c 2/fs/btrfs/transaction.c
--- 1/fs/btrfs/transaction.c 2008-12-13 12:35:29.487886730 +0800
+++ 2/fs/btrfs/transaction.c 2008-12-21 19:09:09.000000000 +0800
@@ -804,7 +804,7 @@ static noinline int finish_pending_snaps
parent_inode = pending->dentry->d_parent->d_inode;
parent_root = BTRFS_I(parent_inode)->root;
- trans = btrfs_start_transaction(parent_root, 1);
+ trans = btrfs_join_transaction(parent_root, 1);
/*
* insert the directory item
next prev parent reply other threads:[~2008-12-22 0:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 14:09 btrfs filesystem freeze devzero
2008-12-22 0:55 ` Yan Zheng [this message]
2009-01-05 15:44 ` Chris Mason
2009-01-05 21:14 ` Yan Zheng
2009-01-05 21:24 ` Chris Mason
-- strict thread matches above, loose matches on Subject: below --
2008-12-23 0:26 devzero
2008-12-20 23:26 devzero
2008-12-21 11:13 ` Yan Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494EE585.5090209@oracle.com \
--to=zheng.yan@oracle.com \
--cc=devzero@web.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.