From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 07/12] cfg80211: allow driver read access to cfg80211_regdomain
Date: Tue, 13 Jan 2009 23:53:58 +0100 [thread overview]
Message-ID: <1231887238.3728.8.camel@johannes> (raw)
In-Reply-To: <20090113225112.GT4416@tesla>
[-- Attachment #1: Type: text/plain, Size: 753 bytes --]
On Tue, 2009-01-13 at 14:51 -0800, Luis R. Rodriguez wrote:
> On Tue, Jan 13, 2009 at 02:46:59PM -0800, Johannes Berg wrote:
> > On Tue, 2009-01-13 at 11:57 -0800, Luis R. Rodriguez wrote:
> > > A driver's reg_notfier() may want to inspect the currently set
> > > regulatory domain.
> >
> > > +const struct ieee80211_regdomain *cfg80211_regdomain;
> > > +EXPORT_SYMBOL(cfg80211_regdomain);
> >
> > Can't we just pass it to the notifier instead of exporting it?
>
> I as thinking about that too, sure, either or is fine. Any preference?
I prefer not exporting it. That makes it more local, and saves the
export. Not that I see why we need it at all? You're not using it, so
let's not do anything with it until we need it.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-13 22:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 19:57 [PATCH 00/12] cfg80211/mac80211: fixes/enhancements for reg_notifier() Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 01/12] cfg80211: print correct intersected regulatory domain Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 02/12] cfg80211: add helper to indicate when to follow the driver regd Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 03/12] cfg80211: add option for wiphys to disregard country IEs Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 04/12] cfg80211: split wiphy_update_regulatory() in two Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 05/12] cfg80211: add regulatory_set_custom_rd() Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 06/12] cfg80211: add regdom_intersect_wiphy_regd() Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 07/12] cfg80211: allow driver read access to cfg80211_regdomain Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 08/12] cfg80211: export freq_reg_info() Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 09/12] cfg80211: Fix sanity check on 5 GHz when processing country IE Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 10/12] cfg80211: process user requests only after previous user/driver/core requests Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 11/12] mac80211: allow mac80211 drivers to get to driver priv from wiphy Luis R. Rodriguez
2009-01-13 19:57 ` [PATCH 12/12] cfg80211: Remove CONFIG_WIRELESS_OLD_REGULATORY Luis R. Rodriguez
2009-01-13 22:50 ` Johannes Berg
2009-01-13 23:00 ` Luis R. Rodriguez
2009-01-13 23:02 ` Johannes Berg
2009-01-13 22:50 ` [PATCH 11/12] mac80211: allow mac80211 drivers to get to driver priv from wiphy Johannes Berg
2009-01-13 22:46 ` [PATCH 07/12] cfg80211: allow driver read access to cfg80211_regdomain Johannes Berg
2009-01-13 22:51 ` Luis R. Rodriguez
2009-01-13 22:53 ` Johannes Berg [this message]
2009-01-13 23:02 ` Luis R. Rodriguez
2009-01-13 23:00 ` [PATCH 00/12] cfg80211/mac80211: fixes/enhancements for reg_notifier() Johannes Berg
2009-01-13 23:17 ` Luis R. Rodriguez
2009-01-13 23:23 ` Johannes Berg
2009-01-13 23:59 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231887238.3728.8.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.