Re: [PATCH 00/12] cfg80211/mac80211: fixes/enhancements for reg_notifier()

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

On Tue, 2009-01-13 at 15:17 -0800, Luis R. Rodriguez wrote:
> > (2) you
> > should not do via the regulatory code and the notifier but rather by not
> > registering those channels to start with
> 
> I did a lot of this work because you had opposed to allow drivers dynamically register
> their channels. 

I think we may have had some miscommunication here? I didn't like
registering the channels dynamically with new calls, but I certainly
don't care how you arrive at your channel array, you can kmalloc it if
you want.

> The size of the code also increases considerably by using static set of
> channels for each custom regulatory domain, its possible though.

You don't have to.

> >, or setting the disabled flag
> > before registration if that's easier.
> 
> You'll still need some sort of table. Either way -- all these are options of how to
> accomplish the same task. I did this as part of cfg80211 as I figured it could be
> used by other drivers.

In what form do you have this data? Is it "valid 2412-2472 and 4950-5250
MHz"? If so, can we just have a function that marks all channel that
would fall outside these ranges as invalid, and you call that function
with a specific band and channel before registering your wiphy?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]