From: Pavel Roskin <proski@gnu.org>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: orinoco-devel@lists.sourceforge.net, linux-wireless@vger.kernel.org
Subject: Re: [Orinoco-devel] [PATCH] [2.6.29-rc2] orinoco: use GFP_ATOMIC in kmalloc in orinoco_ioctl_set_genie
Date: Sun, 18 Jan 2009 22:16:04 -0500 [thread overview]
Message-ID: <1232334964.5609.37.camel@dv> (raw)
In-Reply-To: <200901171822.45476.arvidjaar@mail.ru>
On Sat, 2009-01-17 at 18:22 +0300, Andrey Borzenkov wrote:
> Subject: [PATCH] [2.6.29-rc2] orinoco: use GFP_ATOMIC in kmalloc in
> orinoco_ioctl_set_genie
> From: Andrey Borzenkov <arvidjaar@mail.ru>
>
> kmalloc is called with interrupt disabled and may not sleep. This
> fixes this BUG:
Please move kmalloc before the lock. I don't see any reason to allocate
memory with irqs disabled. The contention happens later, when
priv->wpa_ie is freed and assigned a new value.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-01-19 3:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 15:22 [PATCH] [2.6.29-rc2] orinoco: use GFP_ATOMIC in kmalloc in orinoco_ioctl_set_genie Andrey Borzenkov
2009-01-19 3:16 ` Pavel Roskin [this message]
2009-01-20 17:26 ` [Orinoco-devel] " Andrey Borzenkov
2009-01-21 16:24 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232334964.5609.37.camel@dv \
--to=proski@gnu.org \
--cc=arvidjaar@mail.ru \
--cc=linux-wireless@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.