Re: [Orinoco-devel] [PATCH] [2.6.29-rc2] orinoco: use GFP_ATOMIC in kmalloc in orinoco_ioctl_set_genie

["John W. Linville" <linville@tuxdriver.com>]

On Tue, Jan 20, 2009 at 08:26:46PM +0300, Andrey Borzenkov wrote:
> On 19 =D1=8F=D0=BD=D0=B2=D0=B0=D1=80=D1=8F 2009 06:16:04 Pavel Roskin=
 wrote:
> > On Sat, 2009-01-17 at 18:22 +0300, Andrey Borzenkov wrote:
> > > Subject: [PATCH] [2.6.29-rc2] orinoco: use GFP_ATOMIC in kmalloc =
in
> > > orinoco_ioctl_set_genie
> > > From: Andrey Borzenkov <arvidjaar@mail.ru>
> > >
> > > kmalloc is called with interrupt disabled and may not sleep. This
> > > fixes this BUG:
> >
> > Please move kmalloc before the lock.  I don't see any reason to
> > allocate memory with irqs disabled.  The contention happens later,
> > when priv->wpa_ie is freed and assigned a new value.
>=20
> OK.
>=20
> This looks like -stable candidate.

Just FYI, the best way to indicate is to add a line like this after
your Signed-off-by:

Cc: stable@kernel.org

I'll take care of this one.

Thanks,

John
--=20
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html