From: Pavel Roskin <proski@gnu.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Fix typo in chip version check
Date: Wed, 21 Jan 2009 11:48:15 -0500 [thread overview]
Message-ID: <1232556495.17147.4.camel@dv> (raw)
In-Reply-To: <1232538528-14289-1-git-send-email-vasanth@atheros.com>
Hello, Vasanthakumar!
On Wed, 2009-01-21 at 17:18 +0530, Vasanthakumar Thiagarajan wrote:
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> ---
> drivers/net/wireless/ath9k/hw.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
I'm not a developer of ath9k, and I don't know much about the hardware.
However, I think your patch should be better explained.
> - if (AR_SREV_9280(ah)) {
> + if (AR_SREV_9280_10_OR_LATER(ah)) {
It's not a typo. A typo would be something like AR_SREV_9380, that is
never defined. Or maybe a message like "foudn AR9280". AR_SREV_9280 is
defined and has valid uses. If you think it needs to be changed in this
particular case, an explanation is needed. It would be nice if you
mentioned that it fixes something for some hardware.
--
Regards,
Pavel Roskin
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Roskin <proski@gnu.org>
To: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Cc: linville@tuxdriver.com, ath9k-devel@lists.ath9k.org,
Jouni.Malinen@atheros.com, linux-wireless@vger.kernel.org,
Luis.Rodriguez@atheros.com
Subject: Re: [ath9k-devel] [PATCH] ath9k: Fix typo in chip version check
Date: Wed, 21 Jan 2009 11:48:15 -0500 [thread overview]
Message-ID: <1232556495.17147.4.camel@dv> (raw)
In-Reply-To: <1232538528-14289-1-git-send-email-vasanth@atheros.com>
Hello, Vasanthakumar!
On Wed, 2009-01-21 at 17:18 +0530, Vasanthakumar Thiagarajan wrote:
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> ---
> drivers/net/wireless/ath9k/hw.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
I'm not a developer of ath9k, and I don't know much about the hardware.
However, I think your patch should be better explained.
> - if (AR_SREV_9280(ah)) {
> + if (AR_SREV_9280_10_OR_LATER(ah)) {
It's not a typo. A typo would be something like AR_SREV_9380, that is
never defined. Or maybe a message like "foudn AR9280". AR_SREV_9280 is
defined and has valid uses. If you think it needs to be changed in this
particular case, an explanation is needed. It would be nice if you
mentioned that it fixes something for some hardware.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-01-21 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 11:48 [ath9k-devel] [PATCH] ath9k: Fix typo in chip version check Vasanthakumar Thiagarajan
2009-01-21 11:48 ` Vasanthakumar Thiagarajan
2009-01-21 16:48 ` Pavel Roskin [this message]
2009-01-21 16:48 ` [ath9k-devel] " Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232556495.17147.4.camel@dv \
--to=proski@gnu.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.