Reiser4: Compilation Error on 2.6.28.1_[Scanned]

Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Ingo Bormuth]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Reiser4-for-2.6.28 does apply but fails to compile on
vanilla-2.6.28.1 due to the following commit:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=54566b2c1594c2326a645a3551f9d989f7ba3c5e

Attached is a tiny fix which works fine here.


-- 
Ingo Bormuth,  voicebox & telefax:  +49-(0)-12125-10226517
PGP public key 86326EC9 at http://ibormuth.efil.de/contact

[-- Attachment #2: reiser4-for-2.6.28.1-grab_cache_page_write_begin.patch --]
[-- Type: text/x-patch, Size: 400 bytes --]

--- /tmp/reiser4/plugin/file/file_conversion.c	2009-01-19 00:39:04.548008815 +0100
+++ fs/reiser4/plugin/file/file_conversion.c	2009-01-19 00:41:10.956013107 +0100
@@ -686,7 +686,7 @@
 	start = pos & (PAGE_CACHE_SIZE - 1);
 	end = start + len;
 
-	page = __grab_cache_page(mapping, index);
+	page = grab_cache_page_write_begin(mapping, index, flags);
 	*pagep = page;
 	if (!page)
 		return -ENOMEM;

Re: Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Edward Shishkin]

Ingo Bormuth wrote:
> Reiser4-for-2.6.28 does apply but fails to compile on
> vanilla-2.6.28.1 due to the following commit:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=54566b2c1594c2326a645a3551f9d989f7ba3c5e
>
> Attached is a tiny fix which works fine here.
yeah, with your patch it will act as earlier,
however, -mm guys decided to get rig of __GFP_FS flag:
http://userweb.kernel.org/~akpm/mmotm/broken-out/fs-symlink-write_begin-allocation-context-fix-reiser4-fix.patch
it seems they found it deadlocky..

Thanks,
Edward.

Re: Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Volker Armin Hemmann]

On Montag 19 Januar 2009, Edward Shishkin wrote:
> Ingo Bormuth wrote:
> > Reiser4-for-2.6.28 does apply but fails to compile on
> > vanilla-2.6.28.1 due to the following commit:
> >
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit
> >diff;h=54566b2c1594c2326a645a3551f9d989f7ba3c5e
> >
> > Attached is a tiny fix which works fine here.
>
> yeah, with your patch it will act as earlier,
> however, -mm guys decided to get rig of __GFP_FS flag:
> http://userweb.kernel.org/~akpm/mmotm/broken-out/fs-symlink-write_begin-all
>ocation-context-fix-reiser4-fix.patch it seems they found it deadlocky..

so without Ingo Bormuth's patch you can't use r4 with 2.6.28.1 and later and 
with his patch there is a risk of deadlocks?

Glück Auf,
Volker
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Volker Armin Hemmann]

On Montag 19 Januar 2009, Edward Shishkin wrote:
> Ingo Bormuth wrote:
> > Reiser4-for-2.6.28 does apply but fails to compile on
> > vanilla-2.6.28.1 due to the following commit:
> >
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit
> >diff;h=54566b2c1594c2326a645a3551f9d989f7ba3c5e
> >
> > Attached is a tiny fix which works fine here.
>
> yeah, with your patch it will act as earlier,
> however, -mm guys decided to get rig of __GFP_FS flag:
> http://userweb.kernel.org/~akpm/mmotm/broken-out/fs-symlink-write_begin-all
>ocation-context-fix-reiser4-fix.patch it seems they found it deadlocky..

so without Ingo Bormuth's patch you can't use r4 with 2.6.28.1 and later and 
with his patch there is a risk of deadlocks?

Glück Auf,
Volker

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Edward Shishkin]

Volker Armin Hemmann wrote:
> On Montag 19 Januar 2009, Edward Shishkin wrote:
>   
>> Ingo Bormuth wrote:
>>     
>>> Reiser4-for-2.6.28 does apply but fails to compile on
>>> vanilla-2.6.28.1 due to the following commit:
>>>
>>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit
>>> diff;h=54566b2c1594c2326a645a3551f9d989f7ba3c5e
>>>
>>> Attached is a tiny fix which works fine here.
>>>       
>> yeah, with your patch it will act as earlier,
>> however, -mm guys decided to get rig of __GFP_FS flag:
>> http://userweb.kernel.org/~akpm/mmotm/broken-out/fs-symlink-write_begin-all
>> ocation-context-fix-reiser4-fix.patch it seems they found it deadlocky..
>>     
>
> so without Ingo Bormuth's patch you can't use r4 with 2.6.28.1

Ingo's patch is against -rc

>  and later and 
> with his patch there is a risk of deadlocks?
>   

Not sure.
Nobody complained so far..

Edward.

Re: Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Volker Armin Hemmann]

On Sonntag 25 Januar 2009, Edward Shishkin wrote:
> Volker Armin Hemmann wrote:
> > On Montag 19 Januar 2009, Edward Shishkin wrote:
> >> Ingo Bormuth wrote:
> >>> Reiser4-for-2.6.28 does apply but fails to compile on
> >>> vanilla-2.6.28.1 due to the following commit:
> >>>
> >>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=comm
> >>>it diff;h=54566b2c1594c2326a645a3551f9d989f7ba3c5e
> >>>
> >>> Attached is a tiny fix which works fine here.
> >>
> >> yeah, with your patch it will act as earlier,
> >> however, -mm guys decided to get rig of __GFP_FS flag:
> >> http://userweb.kernel.org/~akpm/mmotm/broken-out/fs-symlink-write_begin-
> >>all ocation-context-fix-reiser4-fix.patch it seems they found it
> >> deadlocky..
> >
> > so without Ingo Bormuth's patch you can't use r4 with 2.6.28.1
>
> Ingo's patch is against -rc
>
> >  and later and
> > with his patch there is a risk of deadlocks?
>
> Not sure.
> Nobody complained so far..

hm, I had two lockups with 2.6.28 and your r4 patch so far. Suddenly the box 
only responded to sysrq - and on reboot the software raid5 with my r4 
partitions on needed a resync. Might be related or not. I am back to 2.6.27 
which never showed any misbehaviour.

Glück Auf,
Volker

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Edward Shishkin]

Volker Armin Hemmann wrote:
> On Sonntag 25 Januar 2009, Edward Shishkin wrote:
>   
>> Volker Armin Hemmann wrote:
>>     
>>> On Montag 19 Januar 2009, Edward Shishkin wrote:
>>>       
>>>> Ingo Bormuth wrote:
>>>>         
>>>>> Reiser4-for-2.6.28 does apply but fails to compile on
>>>>> vanilla-2.6.28.1 due to the following commit:
>>>>>
>>>>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=comm
>>>>> it diff;h=54566b2c1594c2326a645a3551f9d989f7ba3c5e
>>>>>
>>>>> Attached is a tiny fix which works fine here.
>>>>>           
>>>> yeah, with your patch it will act as earlier,
>>>> however, -mm guys decided to get rig of __GFP_FS flag:
>>>> http://userweb.kernel.org/~akpm/mmotm/broken-out/fs-symlink-write_begin-
>>>> all ocation-context-fix-reiser4-fix.patch it seems they found it
>>>> deadlocky..
>>>>         
>>> so without Ingo Bormuth's patch you can't use r4 with 2.6.28.1
>>>       
>> Ingo's patch is against -rc
>>
>>     
>>>  and later and
>>> with his patch there is a risk of deadlocks?
>>>       
>> Not sure.
>> Nobody complained so far..
>>     
>
> hm, I had two lockups with 2.6.28 and your r4 patch so far. Suddenly the box 
> only responded to sysrq

Would you please send the sysrq-t output?

 
>  - and on reboot the software raid5 with my r4 
> partitions on needed a resync. Might be related or not. I am back to 2.6.27 
> which never showed any misbehaviour.
>
> Glück Auf,
> Volker
>
>
>   

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Teran McKinney]

I could build 2.6.28.1 fine with Reiser4, but if I applied Ingo's
patch, it would not build. I've had no issues, but haven't used
Reiser4 heavily at all yet.

Cheers,
Teran

PS: 2.6.28.2 is out.

On Sun, Jan 25, 2009 at 17:44, Edward Shishkin
<edward.shishkin@gmail.com> wrote:
> Volker Armin Hemmann wrote:
>> On Sonntag 25 Januar 2009, Edward Shishkin wrote:
>>
>>> Volker Armin Hemmann wrote:
>>>
>>>> On Montag 19 Januar 2009, Edward Shishkin wrote:
>>>>
>>>>> Ingo Bormuth wrote:
>>>>>
>>>>>> Reiser4-for-2.6.28 does apply but fails to compile on
>>>>>> vanilla-2.6.28.1 due to the following commit:
>>>>>>
>>>>>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=comm
>>>>>> it diff;h=54566b2c1594c2326a645a3551f9d989f7ba3c5e
>>>>>>
>>>>>> Attached is a tiny fix which works fine here.
>>>>>>
>>>>> yeah, with your patch it will act as earlier,
>>>>> however, -mm guys decided to get rig of __GFP_FS flag:
>>>>> http://userweb.kernel.org/~akpm/mmotm/broken-out/fs-symlink-write_begin-
>>>>> all ocation-context-fix-reiser4-fix.patch it seems they found it
>>>>> deadlocky..
>>>>>
>>>> so without Ingo Bormuth's patch you can't use r4 with 2.6.28.1
>>>>
>>> Ingo's patch is against -rc
>>>
>>>
>>>>  and later and
>>>> with his patch there is a risk of deadlocks?
>>>>
>>> Not sure.
>>> Nobody complained so far..
>>>
>>
>> hm, I had two lockups with 2.6.28 and your r4 patch so far. Suddenly the box
>> only responded to sysrq
>
> Would you please send the sysrq-t output?
>
>
>>  - and on reboot the software raid5 with my r4
>> partitions on needed a resync. Might be related or not. I am back to 2.6.27
>> which never showed any misbehaviour.
>>
>> Glück Auf,
>> Volker
>>
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Volker Armin Hemmann]

On Sonntag 25 Januar 2009, you wrote:
> Volker Armin Hemmann wrote:
> > On Sonntag 25 Januar 2009, Edward Shishkin wrote:
> >> Volker Armin Hemmann wrote:
> >>> On Montag 19 Januar 2009, Edward Shishkin wrote:
> >>>> Ingo Bormuth wrote:
> >>>>> Reiser4-for-2.6.28 does apply but fails to compile on
> >>>>> vanilla-2.6.28.1 due to the following commit:
> >>>>>
> >>>>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=co
> >>>>>mm it diff;h=54566b2c1594c2326a645a3551f9d989f7ba3c5e
> >>>>>
> >>>>> Attached is a tiny fix which works fine here.
> >>>>
> >>>> yeah, with your patch it will act as earlier,
> >>>> however, -mm guys decided to get rig of __GFP_FS flag:
> >>>> http://userweb.kernel.org/~akpm/mmotm/broken-out/fs-symlink-write_begi
> >>>>n- all ocation-context-fix-reiser4-fix.patch it seems they found it
> >>>> deadlocky..
> >>>
> >>> so without Ingo Bormuth's patch you can't use r4 with 2.6.28.1
> >>
> >> Ingo's patch is against -rc
> >>
> >>>  and later and
> >>> with his patch there is a risk of deadlocks?
> >>
> >> Not sure.
> >> Nobody complained so far..
> >
> > hm, I had two lockups with 2.6.28 and your r4 patch so far. Suddenly the
> > box only responded to sysrq
>
> Would you please send the sysrq-t output?

I wish I could - but the logs were empty - and I couldn't even make it back to 
vt. X froze partially, no reaction to input, but apps running continued to do 
so, e, i  killed apps, s and u seemed to have some effect and b worked - but 
after that, raid resync and fsck for the mounted ext2 partition went off. I 
did t too - but as I wrote above, there were nothing in the logs. I am not 
blaming r4 - I am using fglrx which could be the cause. 

Glück Auf,
Volker


--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Reiser4: Compilation Error on 2.6.28.1_[Scanned]

[Ingo Bormuth]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Sun, 2009-01-25 at 18:13 +0100, Volker Armin Hemmann wrote:
> so without Ingo Bormuth's patch you can't use r4 with 2.6.28.1 and later and 
> with his patch there is a risk of deadlocks?

After Edward's reply actually I changed to use the attached mm patch
which is actually the same as what I did with additionally setting the
AOP_FLAG_NOFS flag before calling grab_cache_page_write_begin. It
applies and works nicely with vanilla 2.6.28.2 too.



-- 
Ingo Bormuth,  voicebox & telefax:  +49-(0)-12125-10226517
PGP public key 86326EC9 at http://ibormuth.efil.de/contact

[-- Attachment #2: fs-symlink-write_begin-allocation-context-fix-reiser4-fix.patch --]
[-- Type: text/x-patch, Size: 936 bytes --]

From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

build fix.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/reiser4/plugin/file/file_conversion.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN fs/reiser4/plugin/file/file_conversion.c~fs-symlink-write_begin-allocation-context-fix-reiser4-fix fs/reiser4/plugin/file/file_conversion.c
--- a/fs/reiser4/plugin/file/file_conversion.c~fs-symlink-write_begin-allocation-context-fix-reiser4-fix
+++ a/fs/reiser4/plugin/file/file_conversion.c
@@ -686,7 +686,8 @@ int reiser4_write_begin_careful(struct f
 	start = pos & (PAGE_CACHE_SIZE - 1);
 	end = start + len;
 
-	page = __grab_cache_page(mapping, index);
+	page = grab_cache_page_write_begin(mapping, index,
+					   flags & AOP_FLAG_NOFS);
 	*pagep = page;
 	if (!page)
 		return -ENOMEM;
_