All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Cross-compilation check broken
Date: Thu, 29 Jan 2009 11:19:29 -0500	[thread overview]
Message-ID: <1233245969.2910.19.camel@dv> (raw)
In-Reply-To: <20090129130737.GD15436@thorin>

On Thu, 2009-01-29 at 14:07 +0100, Robert Millan wrote:

> This check looks really confusing.  I naively assumed it was checking if we're
> cross-compiling like the comment said ;-)

I agree, the comment is misleading.  We actually check for the second
set of tools there, which is used to build files for the target.  The
first set is used to build for the host, and it can be a cross-compiler
as well.

> But if it really meant to compare target with host, I think it should be:
> 
>   if test "x$target_cpu" != "x$host_cpu"; then
> 
> rather than what was before:
> 
>   if test "x$target" != "x$host"; then
> 
> Since "$target_os" has no real meaning.  Does that work for you?

I understand that you are trying to exorcise "$target_os" by all means.
By from the user standpoint, the second set of tools is needed if the
"--target" option was specified and its argument is different from the
one for the "--host" option.

I would also like to get rid of ac_tool_prefix.  I'll have a look.  I
assume we can always look for $target_alias-gcc without falling back to
$target_alias-cc and $target_alias-egcs.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2009-01-29 16:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-29  2:14 Cross-compilation check broken Pavel Roskin
2009-01-29 13:07 ` Robert Millan
2009-01-29 16:19   ` Pavel Roskin [this message]
2009-02-07 21:42     ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233245969.2910.19.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.