* [PATCH JGIT] use java 5 like for loops
@ 2009-01-31 14:19 Yann Simon
0 siblings, 0 replies; only message in thread
From: Yann Simon @ 2009-01-31 14:19 UTC (permalink / raw)
To: Shawn O. Pearce, Robin Rosenberg; +Cc: git
in for loops that use an iterator or an index (int i), use instead a
loop like: for (Element e : elements)
Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
---
.../src/org/spearce/jgit/lib/GitIndex.java | 6 ++----
.../src/org/spearce/jgit/lib/Repository.java | 4 ++--
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java
b/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java
index 6eeccff..920a9c9 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java
@@ -754,8 +754,7 @@ public Entry addEntry(TreeEntry te) throws
IOException {
* @throws IOException
*/
public void checkout(File wd) throws IOException {
- for (Iterator i = entries.values().iterator(); i.hasNext();) {
- Entry e = (Entry) i.next();
+ for (Entry e : entries.values()) {
if (e.getStage() != 0)
continue;
checkoutEntry(wd, e);
@@ -808,8 +807,7 @@ public ObjectId writeTree() throws IOException {
Stack<Tree> trees = new Stack<Tree>();
trees.push(current);
String[] prevName = new String[0];
- for (Iterator i = entries.values().iterator(); i.hasNext();) {
- Entry e = (Entry) i.next();
+ for (Entry e : entries.values()) {
if (e.getStage() != 0)
continue;
String[] newName = splitDirPath(e.getName());
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
index e1c4049..038a869 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
@@ -231,8 +231,8 @@ public File toFile(final AnyObjectId objectId) {
String d=n.substring(0, 2);
String f=n.substring(2);
final File[] objectsDirs = objectsDirs();
- for (int i=0; i<objectsDirs.length; ++i) {
- File ret = new File(new File(objectsDirs[i], d), f);
+ for (File objectsDir : objectsDirs) {
+ File ret = new File(new File(objectsDir, d), f);
if (ret.exists())
return ret;
}
--
1.6.0.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-01-31 14:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-31 14:19 [PATCH JGIT] use java 5 like for loops Yann Simon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.