From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Andrea Righi <righi.andrea@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Roman Zippel <zippel@linux-m68k.org>,
David Howells <dhowells@redhat.com>,
Hirokazu Takata <takata@linux-m32r.org>
Subject: Re: [PATCH -mmotm] mm: unify some pmd_*() functions fix
Date: Mon, 02 Feb 2009 14:48:46 +0100 [thread overview]
Message-ID: <1233582526.18006.31.camel@localhost> (raw)
In-Reply-To: <1233183874-26066-1-git-send-email-righi.andrea@gmail.com>
On Thu, 2009-01-29 at 00:04 +0100, Andrea Righi wrote:
> Also unify implementations of pmd_*() functions in arch/*.
>
> This patch must be applied on top of mm-unify-some-pmd_-functions.patch.
>
> Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
> diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h
> index b2658b9..6a85281 100644
> --- a/arch/s390/include/asm/pgalloc.h
> +++ b/arch/s390/include/asm/pgalloc.h
> @@ -63,8 +63,7 @@ static inline unsigned long pgd_entry_type(struct mm_struct *mm)
> #define pud_alloc_one(mm,address) ({ BUG(); ((pud_t *)2); })
> #define pud_free(mm, x) do { } while (0)
>
> -#define pmd_alloc_one(mm,address) ({ BUG(); ((pmd_t *)2); })
> -#define pmd_free(mm, x) do { } while (0)
> +#define pmd_alloc_one pmd_alloc_one_bug
>
> #define pgd_populate(mm, pgd, pud) BUG()
> #define pgd_populate_kernel(mm, pgd, pud) BUG()
This does not compile for 32 bit s390. With the patches for 'dynamic
page tables' and '1K/2k page tables' I decided to get completely
independent from the nopmd/nopud #ifdef hell. The include files from
asm-generic are simply not used for s390. Please drop the above hunk
from your patch and leave s390 as it is.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
WARNING: multiple messages have this Message-ID (diff)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Andrea Righi <righi.andrea@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Roman Zippel <zippel@linux-m68k.org>,
David Howells <dhowells@redhat.com>,
Hirokazu Takata <takata@linux-m32r.org>
Subject: Re: [PATCH -mmotm] mm: unify some pmd_*() functions fix
Date: Mon, 02 Feb 2009 14:48:46 +0100 [thread overview]
Message-ID: <1233582526.18006.31.camel@localhost> (raw)
In-Reply-To: <1233183874-26066-1-git-send-email-righi.andrea@gmail.com>
On Thu, 2009-01-29 at 00:04 +0100, Andrea Righi wrote:
> Also unify implementations of pmd_*() functions in arch/*.
>
> This patch must be applied on top of mm-unify-some-pmd_-functions.patch.
>
> Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
> diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h
> index b2658b9..6a85281 100644
> --- a/arch/s390/include/asm/pgalloc.h
> +++ b/arch/s390/include/asm/pgalloc.h
> @@ -63,8 +63,7 @@ static inline unsigned long pgd_entry_type(struct mm_struct *mm)
> #define pud_alloc_one(mm,address) ({ BUG(); ((pud_t *)2); })
> #define pud_free(mm, x) do { } while (0)
>
> -#define pmd_alloc_one(mm,address) ({ BUG(); ((pmd_t *)2); })
> -#define pmd_free(mm, x) do { } while (0)
> +#define pmd_alloc_one pmd_alloc_one_bug
>
> #define pgd_populate(mm, pgd, pud) BUG()
> #define pgd_populate_kernel(mm, pgd, pud) BUG()
This does not compile for 32 bit s390. With the patches for 'dynamic
page tables' and '1K/2k page tables' I decided to get completely
independent from the nopmd/nopud #ifdef hell. The include files from
asm-generic are simply not used for s390. Please drop the above hunk
from your patch and leave s390 as it is.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-02 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 23:04 [PATCH -mmotm] mm: unify some pmd_*() functions fix Andrea Righi
2009-01-28 23:04 ` Andrea Righi
2009-02-02 13:48 ` Martin Schwidefsky [this message]
2009-02-02 13:48 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233582526.18006.31.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=righi.andrea@gmail.com \
--cc=takata@linux-m32r.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.