From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [PATCH] gfs2/ops_file.c: fix build breakage
Date: Wed, 04 Feb 2009 14:51:19 +0000 [thread overview]
Message-ID: <1233759079.9571.689.camel@quoit> (raw)
In-Reply-To: <20090204144920.GA13319@orion>
Hi,
There is already a patch queued up in -mm to fix this. The issue is not
that GFS2 should depend upon FILE_LOCKING but that generic_setlease
should be defined so that this reference to it is correct even when
FILE_LOCKING is not selected,
Steve.
On Wed, 2009-02-04 at 17:49 +0300, Alexander Beregalov wrote:
> fs/gfs2/ops_file.c:746: error: 'generic_setlease' undeclared here (not
> in a function)
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
>
> fs/gfs2/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
> index 3a981b7..97cefdf 100644
> --- a/fs/gfs2/Kconfig
> +++ b/fs/gfs2/Kconfig
> @@ -7,6 +7,7 @@ config GFS2_FS
> select IP_SCTP if DLM_SCTP
> select FS_POSIX_ACL
> select CRC32
> + select FILE_LOCKING
> help
> A cluster filesystem.
>
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gfs2/ops_file.c: fix build breakage
Date: Wed, 04 Feb 2009 14:51:19 +0000 [thread overview]
Message-ID: <1233759079.9571.689.camel@quoit> (raw)
In-Reply-To: <20090204144920.GA13319@orion>
Hi,
There is already a patch queued up in -mm to fix this. The issue is not
that GFS2 should depend upon FILE_LOCKING but that generic_setlease
should be defined so that this reference to it is correct even when
FILE_LOCKING is not selected,
Steve.
On Wed, 2009-02-04 at 17:49 +0300, Alexander Beregalov wrote:
> fs/gfs2/ops_file.c:746: error: 'generic_setlease' undeclared here (not
> in a function)
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
>
> fs/gfs2/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
> index 3a981b7..97cefdf 100644
> --- a/fs/gfs2/Kconfig
> +++ b/fs/gfs2/Kconfig
> @@ -7,6 +7,7 @@ config GFS2_FS
> select IP_SCTP if DLM_SCTP
> select FS_POSIX_ACL
> select CRC32
> + select FILE_LOCKING
> help
> A cluster filesystem.
>
next prev parent reply other threads:[~2009-02-04 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 14:49 [PATCH] gfs2/ops_file.c: fix build breakage Alexander Beregalov
2009-02-04 14:51 ` Steven Whitehouse [this message]
2009-02-04 14:51 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233759079.9571.689.camel@quoit \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.